Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not determine version for package... #16162

Closed
1 of 15 tasks
juristr opened this issue Nov 12, 2019 · 4 comments
Closed
1 of 15 tasks

Could not determine version for package... #16162

juristr opened this issue Nov 12, 2019 · 4 comments
Labels
freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Milestone

Comments

@juristr
Copy link
Contributor

juristr commented Nov 12, 2019

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

The ng update command fails when a package uses the git+ssh:// or https reference rather than a version number (as you usually have). While this is definitely not best practice, it happens from now and then inside enterprise environments.

A clear and concise description of the problem...

🔬 Minimal Reproduction

Add a package referenced via git+ssh, for instance:

"@biesbjerg/ngx-translate-extract": "git+ssh://git@bitbucket.org:r3_gis_dev/ngx-translate-extract.git#3.0.5-r3patch.01",

...
"dependencies": {
    ...
    "mypackage": "git+ssh://git@...mypackage.git#3.0.5",
}

Having this in the package.json run ng update @angular/core@next @angular/cli@next.

As a concrete example of an external package, this one should also fail:

...
"dependencies": {
    ...
    "material-icon-font": "https://github.com/petergng/materialIconFont.git",
}

🔥 Exception or Error




An unexpected error happened; could not determine version for package ...

🌍 Your Environment




Angular CLI: 8.3.18
Node: 11.6.0
OS: darwin x64
Angular: 8.2.13
... animations, common, compiler, compiler-cli, core, elements
... forms, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.803.18
@angular-devkit/build-angular      0.803.18
@angular-devkit/build-optimizer    0.803.18
@angular-devkit/build-webpack      0.803.18
@angular-devkit/core               8.3.18
@angular-devkit/schematics         8.1.2
@angular/cdk                       8.0.2
@angular/cdk-experimental          8.0.2
@angular/cli                       8.3.18
@angular/flex-layout               8.0.0-beta.26
@angular/material                  8.0.2
@angular/material-moment-adapter   8.0.2
@ngtools/webpack                   8.3.18
@schematics/angular                7.3.9
@schematics/update                 0.803.18
rxjs                               6.5.3
typescript                         3.5.3
webpack                            4.39.2

//cc @filipesilva

@filipesilva filipesilva added comp: schematics/update freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix labels Nov 12, 2019
@ngbot ngbot bot added this to the Backlog milestone Nov 12, 2019
@filipesilva filipesilva modified the milestones: Backlog, v9-blockers Nov 12, 2019
@filipesilva
Copy link
Contributor

I think this is a regression, I remember deps we couldn't identify properly were supposed to be ignored. @clydin might know more.

@alan-agius4
Copy link
Collaborator

Duplicate of #13059

@alan-agius4 alan-agius4 marked this as a duplicate of #13059 Nov 12, 2019
@filipesilva
Copy link
Contributor

Closing in favor of #13059,

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants