Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

The release v0.19.6 contains the release code v0.19.5 #1867

Closed
khusamov opened this issue Dec 8, 2016 · 5 comments
Closed

The release v0.19.6 contains the release code v0.19.5 #1867

khusamov opened this issue Dec 8, 2016 · 5 comments

Comments

@khusamov
Copy link

khusamov commented Dec 8, 2016

The release v0.19.6 contains the release code v0.19.5:

/*!
 * ui-select
 * http://github.com/angular-ui/ui-select
 * Version: 0.19.5 - 2016-10-24T23:13:59.434Z
 * License: MIT
 */

As a result, editing (issue 453) was not included in the release v0.19.6.

@eventengine
Copy link

+111!!

@bman61
Copy link

bman61 commented Dec 14, 2016

FYI Every tag release dist folder contains the previous version number

@eventengine
Copy link

FYI Every tag release dist folder contains the previous version number

What is that fu**ing mean?! 0_o

@bman61
Copy link

bman61 commented Dec 15, 2016

All v0.19.6 dist files contain Version: 0.19.5
All v0.19.5 dist files contain Version: 0.19.4
...
All v0.19.0 dist files contain Version: 0.18.1
...

When a developer is debugging in the browser and looking at the ui-select source file they tend to use the version # in the file itself and not some obscure knowledge that a defective process to release a new build tag contains the previous release # and therefore the developer should know that when they see 0.19.5 it really means they are looking at the 0.19.6 release. Simple and obvious. Not.

As a general rule, this is NOT how 99.99% of projects on github operate.

@Jefiozie
Copy link
Contributor

Jefiozie commented Mar 7, 2017

I understand the confusion but as this is already from 0.18.1) i'm closing the issue as we won't fix this right now.

If somebody is willing to have a look at it and make a PR i'm happy to review

@Jefiozie Jefiozie closed this as completed Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants