Skip to content

Commit 28fd7a3

Browse files
author
Andi Kleen
committed
toplev: Remove unused arguments/functions/simplify expr
1 parent 76b0f4f commit 28fd7a3

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

toplev.py

+5-8
Original file line numberDiff line numberDiff line change
@@ -2436,12 +2436,9 @@ def remove_pp(s):
24362436
def clean_event(e):
24372437
return remove_pp(e).replace(".", "_").replace(":", "_").replace('=','')
24382438

2439-
def do_sample(sample_obj, rest, count, full_olist, ret):
2439+
def do_sample(sample_obj, rest, count, ret):
24402440
samples = [("cycles:pp", "Precise cycles", )]
24412441

2442-
def sample_list(obj):
2443-
return [(s, obj.name) for s in obj.sample]
2444-
24452442
for obj in sample_obj:
24462443
for s in obj.sample:
24472444
samples.append((s, obj.name))
@@ -2531,7 +2528,7 @@ def gen_bn(o):
25312528
return True
25322529
return False
25332530

2534-
def do_xlsx(runner):
2531+
def do_xlsx():
25352532
cmd = "%s %s/tl-xlsx.py --valcsv '%s' --perf '%s' --cpuinfo '%s' " % (
25362533
sys.executable,
25372534
exe_dir(),
@@ -2873,8 +2870,8 @@ def measure_and_sample(count):
28732870
if args.level < runner.max_node_level and runner.bottlenecks:
28742871
repeat = suggest_bottlenecks(runner)
28752872
if (args.show_sample or args.run_sample) and ret == 0:
2876-
do_sample(runner.sample_obj, rest, count, runner.full_olist, ret)
2877-
if ret >= 100 and ret <= 200 and repeat:
2873+
do_sample(runner.sample_obj, rest, count, ret)
2874+
if 100 <= ret <= 200 and repeat:
28782875
print("Perf or workload appears to have failed with error %d. Not drilling down" % ret,
28792876
file=sys.stderr)
28802877
break
@@ -2903,7 +2900,7 @@ def measure_and_sample(count):
29032900
out.flushfiles()
29042901

29052902
if args.xlsx and ret == 0:
2906-
ret = do_xlsx(runner)
2903+
ret = do_xlsx()
29072904

29082905
if runner.idle_keys and not args.quiet:
29092906
print("Idle CPUs %s may have been hidden. Override with --idle-threshold 100" %

0 commit comments

Comments
 (0)