Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RevokeToken via access_token method. #32

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Conversation

dlipford360
Copy link
Contributor

hey! I needed a revokeToken method and forked your repo and made one. I tested it and it works. maybe unique_id could be renamed to access_token. it just happened that way when I made it.
On my implementation it's use kinda goes like

  • step 1 -> authorization_code passed to BE.
    step 2- > below
//this code is ran. gets accessToken, then uses it to revoke
const access_token = await this.appleAuth.accessToken(authorization_code) 
const revoked_token = await this.appleAuth.revokeToken(
        access_token.access_token,
      )

@shadyshrif
Copy link

shadyshrif commented Mar 11, 2023

Thank you for your PR, I really wanted this feature! @ananay could you please merge this?

@ananay
Copy link
Owner

ananay commented Mar 11, 2023

Sorry I missed this! Thanks for the ping. I can go ahead and test this and merge this.

It's high time that this repo also gets a CI/CD pipeline to make it easy to test stuff out.

@ananay ananay merged commit 6f59f66 into ananay:master Mar 12, 2023
@ananay
Copy link
Owner

ananay commented Mar 12, 2023

@dlipford360 thanks for your PR! Merged.
@shadyshrif Released v1.0.8 with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants