feat(cleanup): register atexit handlers to clear events on exit

Added atexit handlers in ActiveWindowWidget, CavaWidget, and TaskbarWidget to ensure proper cleanup of event services when the application exits. This improves resource management and prevents potential memory leaks.

Author: amnweb

src/core/widgets/yasb/active_window.py

@@ -12,6 +12,7 @@
 import win32gui
 from core.utils.win32.app_icons import get_window_icon
 from core.utils.widgets.animation_manager import AnimationManager
+import atexit
 
 IGNORED_TITLES = ['', ' ', 'FolderView', 'Program Manager', 'python3', 'pythonw3', 'YasbBar', 'Search', 'Start', 'yasb']
 IGNORED_CLASSES = ['WorkerW', 'TopLevelWindowForOverflowXamlIsland', 'Shell_TrayWnd', 'Shell_SecondaryTrayWnd']
@@ -121,8 +122,12 @@ def __init__(
 
         self.focus_change_workspaces.connect(self._on_focus_change_workspaces)
         self._event_service.register_event("workspace_update", self.focus_change_workspaces)
- 
+        
+        atexit.register(self._stop_events)
 
+    def _stop_events(self) -> None:
+        self._event_service.clear()
+        
     def _on_focus_change_workspaces(self, event: str) -> None:
         # Temporary fix for MoveWindow event from Komorebi: MoveWindow event is not sending enough data to know on which monitor the window is being moved also animation is a problem and because of that we are using singleShot to try catch the window after the animation is done and this will run only on MoveWindow event
         if event in ['Hide', 'Destroy']:

src/core/widgets/yasb/cava.py

@@ -11,6 +11,7 @@
 from PyQt6.QtWidgets import QHBoxLayout, QWidget, QLabel, QApplication
 from PyQt6.QtGui import QLinearGradient, QPainter, QColor
 from PyQt6.QtCore import QTimer, pyqtSignal
+import atexit
 
 class CavaBar(QWidget):
     def __init__(self, cava_widget):
@@ -122,8 +123,8 @@ def __init__(
 
         # Connect signal and start audio processing
         self.samplesUpdated.connect(self.on_samples_updated)
+        self.destroyed.connect(self.stop_cava)
         self.start_cava()
-        
 
         # Set up auto-hide timer for silence
         if self._hide_empty and self._sleep_timer > 0:
@@ -134,12 +135,16 @@ def __init__(
 
         if QApplication.instance():
             QApplication.instance().aboutToQuit.connect(self.stop_cava)
+        atexit.register(self.stop_cava)   
 
     def stop_cava(self) -> None:
         self._stop_cava = True
+        if hasattr(self, "_cava_process") and self._cava_process.poll() is None:
+            self._cava_process.terminate()
         if hasattr(self, "thread_cava") and self.thread_cava.is_alive():
-            self.thread_cava.join()
-        
+            if threading.current_thread() != self.thread_cava:
+                self.thread_cava.join()
+
     def initialize_colors(self) -> None:
         self.foreground_color = QColor(self._foreground)
         if self._gradient == 1:
@@ -169,6 +174,7 @@ def hide_bar_frame(self) -> None:
         self.hide()
         self._hide_cava_widget = True
 
+
     def start_cava(self) -> None:
         # Build configuration file, temp config file will be created in %temp% directory
         config_template = textwrap.dedent(f"""\
@@ -211,7 +217,7 @@ def process_audio():
                 with open(cava_config_path, "w") as config_file:
                     config_file.write(config_template)
                     config_file.flush()
-                process = subprocess.Popen(
+                self._cava_process = subprocess.Popen(
                     ["cava", "-p", cava_config_path],
                     stdout=subprocess.PIPE,
                     creationflags=subprocess.CREATE_NO_WINDOW
@@ -220,7 +226,7 @@ def process_audio():
                 fmt = bytetype * self._bars_number
                 while True:
                     try:
-                        data = process.stdout.read(chunk)
+                        data = self._cava_process.stdout.read(chunk)
                     except Exception as e:
                         return
                     if len(data) < chunk:
@@ -231,8 +237,9 @@ def process_audio():
                     self.samplesUpdated.emit(samples)
             except Exception as e:
                 logging.error(f"Error processing audio in Cava: {e}")
+                self.stop_cava()
             finally:
-                process.terminate()
+                self.stop_cava()
 
         self.thread_cava = threading.Thread(target=process_audio, daemon=True)
         self.thread_cava.start()

src/core/widgets/yasb/taskbar.py

@@ -13,6 +13,7 @@
 from PIL import Image
 import win32gui
 import win32con
+import atexit
 
 try:
     from core.utils.win32.event_listener import SystemEventListener
@@ -94,9 +95,10 @@ def __init__(
         self._debounced_foreground_event = None
 
         if QApplication.instance():
-            QApplication.instance().aboutToQuit.connect(self.stop_taskbar_events)
-            
-    def stop_taskbar_events(self) -> None:
+            QApplication.instance().aboutToQuit.connect(self._stop_events)
+        atexit.register(self._stop_events)
+
+    def _stop_events(self) -> None:
         self._event_service.clear()
 
     def _on_update_event(self, hwnd: int, event: WinEvent) -> None: