Fix toggle for status update checks #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the decision to store excluded members in a JSON file explicitly instructed? Wouldn't it be better to have a field in the Also, the commit message could be improved by briefly explaining the feature or fix. Same goes for the PR Name. Check out this article for some best practices. |
|
I'll edit the code by having a field in member table and have a proper commit message and PR name. |
|
A few thoughts:
|
|
Closing assuming it's not being worked on anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29
2 new files have been added which are command.rs and storage.rs which are for implementing a command and storing the usernames respectively, and function status_updates_check has some lines added which will exclude the members when checking for status updates. This command can be registered in the main and can be used to exclude some members with their user id's.