Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hint text: increase contrast or remove it as a separate element #250

Closed
sulthan-ahmed opened this issue Jun 8, 2016 · 10 comments
Closed

Comments

@sulthan-ahmed
Copy link

Problem: Registered traveller programme, benjystanton (from DVLA), alextorrance_gds have found in their user research that grey is causing some issues from an accessibility perspective. It is difficult for those with visual impairment to read it.

Alex quite rightly points out that in the examples of elements because think they have to use it everywhere

Solution:

  1. Make hint text black but why then do we need a css class for it?
  2. Remove it but that will have an impact to so many gov forms especially for hof based forms like ours?
@joelanman joelanman changed the title hint text: Paint it black peeps or remove it all together hint text: increase contrast or remove it as a separate element Jun 8, 2016
@gemmaleigh
Copy link
Contributor

I think the simplest solution would be to override color: $secondary-text-colour set for .hint-text.
You need a class for it, as it sets bottom padding - between the hint text and the label.

It would be great if evidence of this could be passed on to @timpaul, who is prioritising work for existing patterns that we need to revise.

@sulthan-ahmed
Copy link
Author

sulthan-ahmed commented Jun 9, 2016

font-colour not compliant by WCAG standards for AAA

pasted image at 2016_06_09 10_08 am

@gemmaleigh
Copy link
Contributor

gemmaleigh commented Jun 9, 2016

That's right, it passes contrast ratio requirements for large text - 18px or above.
Hint text is the same size as body text, at 19px.

My suggestion above was to override this colour (so use a darker colour, e.g. $text-colour) if the existing .hint-text colour ($secondary-text-colour) is too light.

@edwardhorsford
Copy link
Contributor

@sulthan-ahmed We aim for AA, not AAA. Higher contrast is generally better though.

I'd be cautious about just changing the colour - some services may be relying on people being able to perceive the difference between body and hint text. Would be good to do some research on how hint texts is currently used.

@sulthan-ahmed
Copy link
Author

@gemmaleigh yes we've done this. @edwardhorsford I agree it needs more thought and concrete data. However, it does seem that the folks I mentioned above have got some user research that can aid this discussion and ultimately come up with a decision.

@accessiblewebuk
Copy link
Member

@sulthan-ahmed as @edwardhorsford says, we require minimum of level AA, but don't currently require above that. It is always difficult to get good colour contrast with background at the same time as good contrast between two types of text with different meaning (but the same background colour for both). This is always a challenge for links if they aren't distinguished in other ways.

@gemmaleigh - the requirement for large text applies to 18pt or above, not 18px. Recent discussions have indicated that a pt generally equates to 1 and a third px, so large text either needs to be minimum 24px, or minimum 19px if it is bold.

@sulthan-ahmed
Copy link
Author

thanks @accessiblewebuk @edwardhorsford I understand the minimum level scheme of AA. I hate writing messages rather than speaking in person because they may not come out as the most polite. With the greatest respect to you both, should we look to help our users rather than concentrating on meeting a minimum level? Should we not look to improve beyond AA? There is evidence from the Home office, DVLA and GDS to say our users have had problems with grey.

However, I think @edwardhorsford does make a good point about the impact this will have. I also agree that it would be good to have concrete evidence behind this

@accessiblewebuk
Copy link
Member

@sulthan-ahmed It is always good to go beyond the guidelines where possible, but we prioritise meeting the minimum across all the success criteria, and making levels of contrast higher could create problems for some users so more research is needed in that area (we know there are users who require lower than normal contrast and there are issues with changing the default settings in Firefox for example, and for some dyslexic users very high contrast can cause problems).

@sulthan-ahmed
Copy link
Author

fair points @accessiblewebuk 👍

@NickColley
Copy link
Contributor

Following the launch of the GOV.UK Design System, GOV.UK Elements will now only get major bug fixes and security patches.

Since this has not had any activity for a long time I'm going to close this out since the current colour meets the WCAG Level AA contrast requirements.

If you can get the original research or find this is still a problem please raise this on the GOV.UK Design System backlog so we can look into it: alphagov/govuk-design-system-backlog#51

Thanks for raising :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants