Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kit handles line endings consistently #1696

Closed
4 tasks
lfdebrux opened this issue Oct 20, 2022 · 3 comments
Closed
4 tasks

Ensure kit handles line endings consistently #1696

lfdebrux opened this issue Oct 20, 2022 · 3 comments
Assignees

Comments

@lfdebrux
Copy link
Member

lfdebrux commented Oct 20, 2022

What

We currently use Unix line endings everywhere (see #1738), but some users might want to use Windows line endings. In those cases, when the kit creates new files, it should create them with Windows line endings also. Let's update our code to do that.

Why

We should use line endings consistently, and also respect the line endings users currently have.

Who needs to work on this

Developer

Who needs to review this

Tech lead

Done when

  • Decide on a way to detect or give user option to choose line endings
  • When we create a starter prototype all files use the same line endings
  • After migration files keep their line endings and have consistent line endings
  • When generating temporary files the line endings are consistent within each file
@lfdebrux lfdebrux assigned lfdebrux and nataliecarey and unassigned lfdebrux Oct 20, 2022
@lfdebrux lfdebrux added 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) and removed 🐛 Bug Something isn't working the way it should (including incorrect wording in documentation) labels Nov 1, 2022
@lfdebrux
Copy link
Member Author

We could look at the git eol config for this.

@joelanman
Copy link
Contributor

to help try and prioritise this - what bad outcomes could this avoid? Or, whats the worst thing that could happen?

@ruthhammond
Copy link

Closed until this is raised as an issue by a user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants