Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for password page #1609

Closed
1 task
joelanman opened this issue Sep 16, 2022 · 3 comments
Closed
1 task

Add tests for password page #1609

joelanman opened this issue Sep 16, 2022 · 3 comments
Assignees
Labels
🕔 Days A few unknowns, but we roughly know what’s involved.

Comments

@joelanman
Copy link
Contributor

What

Add tests for the password page

Why

We need to ensure the password page works

Who needs to work on this

  • developers

Who needs to review this

  • developers

Done when

  • We have tests for the password page
@joelanman joelanman modified the milestone: v13 Sep 29, 2022
@ruthhammond ruthhammond added the 🕔 Days A few unknowns, but we roughly know what’s involved. label Oct 5, 2022
@ruthhammond ruthhammond added this to the v13 milestone Oct 5, 2022
@ruthhammond
Copy link

Ideally these tests would be in place prior to the release of v13, but it isn't essential

@ruthhammond
Copy link

Further discussion required whether we want to prioritise this

@lfdebrux
Copy link
Member

lfdebrux commented Oct 5, 2022

As part of this work we should consider making it so that we can enable useAuth in tests without also needing to set NODE_ENV=production. Ideally we should be able to just set useAuth=true in an environment variable or config file, currently you need to set NODE_ENV=production USE_AUTH=true USE_HTTPS=false. The need to set NODE_ENV for the auth code to be operable is particularly problematic for automated tests. As @joelanman pointed out currently we expect users to be able to set "useAuth": true in their config file and expect that to enable auth in production but not locally. I'm not sure that behaviour makes sense going forward though, especially because we now have defaults in code rather than in the distributed config files. I'd suggest that instead we make the default of useAuth depend on NODE_ENV, with it defaulting to true in production and false in development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Days A few unknowns, but we roughly know what’s involved.
Projects
None yet
Development

No branches or pull requests

5 participants