Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Internet Explorer 8 support #1394

Closed
2 tasks done
joelanman opened this issue Jun 14, 2022 · 2 comments · Fixed by #1449
Closed
2 tasks done

Remove Internet Explorer 8 support #1394

joelanman opened this issue Jun 14, 2022 · 2 comments · Fixed by #1449
Assignees
@lfdebrux @BenSurgisonGDS
Labels
🕔 Days A few unknowns, but we roughly know what’s involved.
Milestone
v13

Comments

@joelanman
Copy link
Contributor

joelanman commented Jun 14, 2022 •
edited by lfdebrux
Loading

What

Remove IE 8 support

  • the IE 8 scss files
  • any other code supporting ie8

Why

There's no longer any requirement to support IE8 specifically

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • IE 8 specific code removed
  • Documented in changelog as a breaking change
@joelanman joelanman added awaiting triage 🕔 Days A few unknowns, but we roughly know what’s involved. labels Jun 14, 2022
@lfdebrux lfdebrux mentioned this issue Jun 24, 2022
Merged
@lfdebrux
Copy link
Member

lfdebrux commented Jun 27, 2022 •
edited
Loading

Part of this was done in #1428, and the rest of the code was removed in #1434.

@lfdebrux lfdebrux added this to the v13 milestone Jun 29, 2022
@lfdebrux
Copy link
Member

I think all the code has been removed, but we haven't yet added anything to the changelog about it. I'll draft something as a PR.

@lfdebrux lfdebrux self-assigned this Jun 29, 2022
@lfdebrux lfdebrux changed the title Remove IE 8 support Remove Internet Explorer 8 support Jun 29, 2022
@lfdebrux lfdebrux mentioned this issue Jun 29, 2022
Merged
@lfdebrux lfdebrux linked a pull request Jun 29, 2022 that will close this issue
Update changelog with recent major changes #1449
Merged
@lfdebrux lfdebrux mentioned this issue Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfdebrux lfdebrux

@BenSurgisonGDS BenSurgisonGDS

Labels
🕔 Days A few unknowns, but we roughly know what’s involved.
Projects
None yet
Milestone
v13
Development

Successfully merging a pull request may close this issue.

Update changelog with recent major changes alphagov/govuk-prototype-kit
4 participants
@lfdebrux @joelanman @Izabela-16 @BenSurgisonGDS