Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip link component loses underline when global styles are enabled #1641

Closed
frankieroberto opened this issue Nov 13, 2019 · 0 comments · Fixed by #1676
Closed

Skip link component loses underline when global styles are enabled #1641

frankieroberto opened this issue Nov 13, 2019 · 0 comments · Fixed by #1676
Assignees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.

Comments

@frankieroberto
Copy link
Contributor

When the $govuk-global-styles: true; option is enabled, the skip link component does not have an underline.

This can be seen if you download the GOV.UK Prototype Kit, which has the option enabled by default.

The lack of underline is because the link acquires the default focus style of being black-on-yellow with a black bottom-border:

.govuk-link:focus, a:focus {
  outline: 3px solid transparent;
  color: #0b0c0c;
  background-color: #ffdd00;
  box-shadow: 0 -2px #ffdd00, 0 4px #0b0c0c;
  text-decoration: none;
}
@NickColley NickColley added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) awaiting triage Needs triaging by team labels Nov 13, 2019
@kellylee-gds kellylee-gds added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting triage Needs triaging by team labels Nov 20, 2019
@NickColley NickColley self-assigned this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants