From 326033111bebb37f02468e08912c516ad6efeef7 Mon Sep 17 00:00:00 2001 From: "beeps (Kim Grey)" Date: Thu, 30 Mar 2023 11:16:07 +0100 Subject: [PATCH] Update default link underline offset setting --- CHANGELOG.md | 3 ++- src/govuk/settings/_links.scss | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c971b79d8..4912eb2d24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,7 +54,7 @@ The [Button](https://design-system.service.gov.uk/components/button/) Nunjucks m This was added in [pull request #3344: Adding optional id attribute to button component](https://github.com/alphagov/govuk-frontend/pull/3344). Thanks to [Tom Billington](https://github.com/TomBillingtonUK) for this contribution. -### Added a modifier for text input styles that accept sequences of digits +#### Added a modifier for text input styles that accept sequences of digits We've added a new `.govuk-input--extra-letter-spacing` class for [Text Input](https://design-system.service.gov.uk/components/text-input/). This increases readability of text inputs that receive sequences of digits (like security codes, references or phone numbers). @@ -96,6 +96,7 @@ We’ve made fixes to GOV.UK Frontend in the following pull requests: - [#3306: Re-enable complete hover link styles on the footer](https://github.com/alphagov/govuk-frontend/pull/3306) - [#3312: Add default value for warning text icon fallback attribute](https://github.com/alphagov/govuk-frontend/pull/3312) - [#3426: Add organisation brand colour for Department for Business & Trade](https://github.com/alphagov/govuk-frontend/pull/3426) - thanks to [Barbara Slawinska](https://github.com/baisa) for contributing this change +- [#3454: Update default link underline offset setting](https://github.com/alphagov/govuk-frontend/pull/3454) ## 4.5.0 (Feature release) diff --git a/src/govuk/settings/_links.scss b/src/govuk/settings/_links.scss index 2088e8a963..f1dc5d3364 100644 --- a/src/govuk/settings/_links.scss +++ b/src/govuk/settings/_links.scss @@ -38,12 +38,16 @@ $govuk-link-underline-thickness: unquote("max(1px, .0625rem)") !default; /// Offset of link underlines from text baseline /// +/// The default is 3px expressed as ems, as calculated against the default body +/// font size (on desktop) of 19px. +/// 3 ÷ 19 = 0.1578 +/// /// Set this variable to `false` to avoid setting an offset. /// /// @type Number /// @access public -$govuk-link-underline-offset: .1em !default; +$govuk-link-underline-offset: .1578em !default; /// Thickness of link underlines in hover state ///