Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Docker Image for C.I. #14

Closed
Tracked by #48
tzaffi opened this issue May 8, 2022 · 1 comment
Closed
Tracked by #48

Use Docker Image for C.I. #14

tzaffi opened this issue May 8, 2022 · 1 comment
Labels
enhancement New feature or request Team Scytale

Comments

@tzaffi
Copy link
Contributor

tzaffi commented May 8, 2022

Description

Graviton was introduced into PyTeal's C.I. process in its PR #249. In that PR, a docker image of our Sandbox algod was introduced. This approach is significantly faster and more lightweight compared to the approach taken in this repo: build the sandbox from scratch each time, but leverage Github Action docker layer caching). We should.

Action Item

Modify Makefile and .github/workflows/build.yml to mimic those of PyTeal with regards to running the integration tests.
@tzaffi tzaffi mentioned this issue May 8, 2022
Closed
@tzaffi tzaffi added enhancement New feature or request scytale labels May 8, 2022
@algoanne algoanne removed the scytale label Dec 27, 2022
@tzaffi tzaffi mentioned this issue Jan 13, 2023
Merged
2 tasks
@tzaffi
Copy link
Contributor Author

tzaffi commented Jan 13, 2023

Addressed by #48

@tzaffi tzaffi closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Team Scytale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@winder @tzaffi @algoanne