File tree 2 files changed +4
-5
lines changed
2 files changed +4
-5
lines changed Original file line number Diff line number Diff line change 32
32
uses : nick-fields/retry@v3
33
33
with :
34
34
timeout_minutes : 15
35
- retry_wait_seconds : 60
36
- max_attempts : 4
35
+ retry_wait_seconds : 30
36
+ max_attempts : 3
37
37
command : make install test
Original file line number Diff line number Diff line change @@ -627,8 +627,7 @@ def test_tunnel_definitions_v3(self):
627
627
http_tunnel = ngrok .connect (name = "http-tunnel" , pyngrok_config = pyngrok_config )
628
628
ssh_tunnel = ngrok .connect (name = "tcp-tunnel" , pyngrok_config = pyngrok_config )
629
629
time .sleep (1 )
630
- response = urlopen (http_tunnel .public_url )
631
- time .sleep (3 )
630
+ response_body = urlopen (http_tunnel .public_url ).read ().decode ()
632
631
633
632
# THEN
634
633
self .assertEqual (http_tunnel .name , "http-tunnel" )
@@ -637,7 +636,7 @@ def test_tunnel_definitions_v3(self):
637
636
self .assertTrue (http_tunnel .config ["addr" ].startswith ("http://" ))
638
637
self .assertEqual (http_tunnel .public_url ,
639
638
f"https://{ config ['tunnels' ]['http-tunnel' ]['subdomain' ]} .ngrok.io" )
640
- self .assertIn ("Sign in - Google Accounts" , response . read (). decode () )
639
+ self .assertIn ("Sign in - Google Accounts" , response_body )
641
640
self .assertEqual (ssh_tunnel .name , "tcp-tunnel" )
642
641
self .assertEqual (ssh_tunnel .config ["addr" ],
643
642
f"localhost:{ config ['tunnels' ]['tcp-tunnel' ]['addr' ]} " )
You can’t perform that action at this time.
0 commit comments