Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Feedback milestone 2 #30

Open
ThomasVrancken opened this issue Jun 4, 2024 · 0 comments
Open

Feedback milestone 2 #30

ThomasVrancken opened this issue Jun 4, 2024 · 0 comments

Comments

@ThomasVrancken
Copy link
Collaborator

Hi all,

I missed the PR for MS2 so here is our feedback:

Thanks for the work on this project!
You truly did an outstanding implementation. You went above and beyond on pretty much all components of the project. Many best practices were implemented on your own initiative, often before being covered in the class. I hope you still learned useful things during the course and, of course, project.

Here is some feedback per different sprints:

Sprint 1

+Nice context (stat on lost crop to disease)
+Product approach (UX, pricing, …)
+Use of Gitflow (and well documented in README)
-Could have been interesting to comment on who possible users would be

Sprint 2

+Good EDA
+Nice modeling with 3 sizes and prices
+Custom model (Alexnet)
+W&B for tracking training

Sprint 3

+Clean deployment
+Good to have an API key to control access
+Creative to use VPS
+Pytorch prebuilt image
+Secret manager
+Use of PostMan
+Low latency
-It could have been interesting to use a more common cloud provider

Sprint 4

+Vertex AI training (very good)
+CICD triggered training
-ML pipeline missing, though it was not a hard requirement

Sprint 5

+Very clean and thorough use of CICD
+Github secrets
+Train is triggered per commit name (much better than e.g. having a dedicated training branch)
+UI showing probability is nice UI → If incorrect users know why

Extra feedback

+Diagram architecture, super clear how different components interact
+Super clear documentation (README overview, which components from the project description were implemented, use of Gitflow, …)
+“The Foresters” → nice
-One student presented just the data part, less uniform presentation time

You can look back proudly to what you implemented. You show clear potential in software engineering and developing ML Systems.
I suggest showcasing your project when applying to jobs, it’s a good vitrine into what you can do.

Hope you had fun and learned interesting things.

Feel free to reach out if you have any questions.

Best regards,
Thomas Vrancken & Matthias Pirlet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant