Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Length of audio files displayed in a non-human-friendly way #3274

Open
jlstro opened this issue Aug 14, 2023 · 3 comments
Open

BUG: Length of audio files displayed in a non-human-friendly way #3274

jlstro opened this issue Aug 14, 2023 · 3 comments
Labels
bug Things that should work, but don’t good first issue Issues that are well suited for first-time contributors Low issue that could require attention

Comments

@jlstro
Copy link
Contributor

jlstro commented Aug 14, 2023

Describe the bug
The metadata section of audio files displays the length of a recording in seconds with 3 decimal points in accuracy. While this is correct information, it's not very readable and might create confusion.

To Reproduce
Steps to reproduce the behavior:

  1. Upload an adio recording, for example an mp3 file
  2. Wait until the file is processed
  3. Look at metadata section

Expected behavior
It would be easier to understand if the length was displayed in hh:mm:ss or a similar format.

Aleph version
3.15.1rc1

Screenshots
image

@jlstro jlstro added bug Things that should work, but don’t triage These issues need to be reviewed by the Aleph team labels Aug 14, 2023
@Rosencrantz Rosencrantz removed the triage These issues need to be reviewed by the Aleph team label Aug 29, 2023
@Rosencrantz
Copy link
Contributor

Just a note here...

I agree that the duration should be human readable, but we need to be mindful of the duration and how this impacts what should be displayed to the user. Thus:

  • if the duration in less than 1 second we should display as ms
  • from 1 second to 59 seconds display should be seconds + milliseconds
  • from 1 minute to 1 hour display should be minutes + seconds
  • from 1 hour to 1 day display should be hour + minutes

It's unlikely that we'll have audio/video that is greater in length that 24hrs or less than 1 second. But we should adjust the display appropriately.

@Rosencrantz Rosencrantz added Low issue that could require attention good first issue Issues that are well suited for first-time contributors labels Aug 29, 2023
@tillprochaska
Copy link
Contributor

Just some notes for future reference: To implement this in a generic way we’d probably need to introduce a new FtM property type for durations. Right now, properties like Audio:duration use the number property type. This would then allow us to customize how properties of this type are rendered in the Aleph UI.

@tillprochaska
Copy link
Contributor

tillprochaska commented Sep 26, 2023

Related: This is what the search facet for number (and unless otherwise implemented for new duration) properties looks like. Might make sense to tackle that at the same time and implement a range slider or something like that.

Screen Shot 2023-09-26 at 09 50 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that should work, but don’t good first issue Issues that are well suited for first-time contributors Low issue that could require attention
Projects
None yet
Development

No branches or pull requests

3 participants