Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two routers, one for Main Application and one for Share application #2338

Closed
arribbar opened this issue Sep 5, 2017 · 4 comments
Closed

Comments

@arribbar
Copy link

arribbar commented Sep 5, 2017

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.0-beta17
  • react-native v0.47.1

Description

I have an application using RNRF with all routes. I created a share application, to be able to share photos with my main application on Android.

Old config in RNRF v3

I was creating two different routers for the main app and the share app. It was working fine.

I had to change routers component to be stateless to prevent warnings and doing so, my router component for the share part is not working anymore.
There is an error in getScreenForRouteName, line 21 saying `There is no route defined for key mainApplication. Must be one of 'shareApplicationRouteOne', 'shareApplicationRouteTwo'

Question

Do I have to do only one router component for the Main App and the Share App? Or is there something else I need to do ?

I made a fork reproducing the bug in Example folder here
https://github.com/arribbar/react-native-router-flux/tree/errorRouter

@arribbar arribbar changed the title Question about using RNRF in Main Application and Share application Bug using RNRF in Main Application and Share application Sep 6, 2017
@arribbar arribbar changed the title Bug using RNRF in Main Application and Share application Two routers, one for Main Application and one for Share application Sep 7, 2017
@arribbar
Copy link
Author

arribbar commented Sep 7, 2017

Well, it was working with an old version of RNRF, 3.38.0

It is not due to stateless components as I thought before, I have still the bug.
I do not have the bug on iOS. This is only for Android.

@arribbar
Copy link
Author

arribbar commented Sep 8, 2017

@aksonov Any idea to help me, please ?

@aksonov
Copy link
Owner

aksonov commented Sep 10, 2017

It is not supported for v4, sorry.

@aksonov aksonov closed this as completed Sep 10, 2017
@arribbar
Copy link
Author

Questions, is it due to react-navigation or react-native-router-flux ?
And what would you advise? Go back to v3.38 or do without router for the share part ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants