Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideTabBar sometimes doesn't work #2076

Closed
luco opened this issue Jul 20, 2017 · 4 comments
Closed

hideTabBar sometimes doesn't work #2076

luco opened this issue Jul 20, 2017 · 4 comments

Comments

@luco
Copy link
Contributor

luco commented Jul 20, 2017

Im having this issue. hideTabBar sometimes does and sometimes does not work.
On my app, for example, the messages inner view does hide the tabBar while the profile doesn't.

<Scene key="tabbar" 
              tabs
              tabBarComponent={this.tabBarElement.bind(this)}
               >

                  <Scene key="home" title="Home">
                    <Scene key="homeMain" title="Home" component={Home} />
                    <Scene key="profile" title="Profile" component={UserProfile}  hideTabBar={true} />
                  </Scene>

                  <Scene key="messages" >
                          <Scene key="messagesMain" title="Messages" component={Messages}/>
                          <Scene key="messageView" component={Message}  hideTabBar={true} />
                        </Scene>

Tips?

@aksonov
Copy link
Owner

aksonov commented Jul 20, 2017

Duplicate of #2012 ? It seems ReactNavigation has issues with TabBar...

@aksonov aksonov marked this as a duplicate of #2012 Jul 20, 2017
@luco
Copy link
Contributor Author

luco commented Jul 20, 2017

@aksonov Figured it out.

I was importing NavBar:
import {Actions, NavBar} from 'react-native-router-flux';

Removing fixed it. Should I submit a PR to Docs to specify that hideTabBar will only work if NavBar is not imported?

@aksonov
Copy link
Owner

aksonov commented Jul 20, 2017

Hm, I can't find correlation between null NavBar - v4 doesn't export it anymore and hideTabBar option... Are you sure that you didn't use that empty NavBar anywhere (so it could broke things) ?

@luco
Copy link
Contributor Author

luco commented Jul 20, 2017

Not that I remember. Just removing it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants