From 371bd1aa904e40dc1f7d695cb959e44a1640a5c3 Mon Sep 17 00:00:00 2001 From: Tim Roes Date: Tue, 28 Jun 2022 19:13:09 +0200 Subject: [PATCH] Remove all @ts-ignore --- airbyte-webapp/.eslintrc | 1 - .../src/components/EntityTable/utils.tsx | 2 +- airbyte-webapp/src/components/Table/Table.tsx | 29 +++++++++---------- .../core/domain/connector/SourceService.ts | 2 +- .../src/core/jsonSchema/schemaToYup.ts | 6 ++-- .../src/core/request/AirbyteRequestService.ts | 2 +- .../cloud/views/auth/components/News.tsx | 1 - .../SideBar/components/SidebarPopout.tsx | 1 - 8 files changed, 19 insertions(+), 25 deletions(-) diff --git a/airbyte-webapp/.eslintrc b/airbyte-webapp/.eslintrc index 679e2b04e46cc..26fa893f823fa 100644 --- a/airbyte-webapp/.eslintrc +++ b/airbyte-webapp/.eslintrc @@ -64,7 +64,6 @@ "@typescript-eslint/ban-ts-comment": [ "warn", { - "ts-ignore": "allow-with-description", "ts-expect-error": "allow-with-description" } ], diff --git a/airbyte-webapp/src/components/EntityTable/utils.tsx b/airbyte-webapp/src/components/EntityTable/utils.tsx index b394dc02f3c51..bc0fb11611c99 100644 --- a/airbyte-webapp/src/components/EntityTable/utils.tsx +++ b/airbyte-webapp/src/components/EntityTable/utils.tsx @@ -46,7 +46,7 @@ export function getEntityTableData< const connectEntities = entityConnections.map((connection) => ({ name: connection[connectType]?.name || "", - // @ts-ignore ts is not that clever to infer such types + // @ts-expect-error ts is not that clever to infer such types connector: connection[connectType]?.[`${connectType}Name`] || "", status: connection.status, lastSyncStatus: getConnectionSyncStatus(connection.status, connection.latestSyncJobStatus), diff --git a/airbyte-webapp/src/components/Table/Table.tsx b/airbyte-webapp/src/components/Table/Table.tsx index ab6da681f5ec2..248aa15587cf0 100644 --- a/airbyte-webapp/src/components/Table/Table.tsx +++ b/airbyte-webapp/src/components/Table/Table.tsx @@ -161,22 +161,19 @@ const Table: React.FC = ({ columns, data, onClickRow, erroredRows, sortB onClick={() => onClickRow?.(row.original)} erroredRows={erroredRows && !!row.original.error} > - { - // @ts-ignore needs to address proper types for table - row.cells.map((cell: ICellProps, key) => { - return ( - - {cell.render("Cell")} - - ); - }) - } + {row.cells.map((cell: ICellProps, key) => { + return ( + + {cell.render("Cell")} + + ); + })} ); })} diff --git a/airbyte-webapp/src/core/domain/connector/SourceService.ts b/airbyte-webapp/src/core/domain/connector/SourceService.ts index 12743f835ae3d..4d81c8dc5aae3 100644 --- a/airbyte-webapp/src/core/domain/connector/SourceService.ts +++ b/airbyte-webapp/src/core/domain/connector/SourceService.ts @@ -86,7 +86,7 @@ export class SourceService extends AirbyteRequestService { const e = new CommonRequestError(result); // Generate error with failed status and received logs e._status = 400; - // @ts-ignore address this case + // @ts-expect-error address this case e.response = result.jobInfo; throw e; } diff --git a/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts b/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts index 635ded6ff13e7..47edec68c932b 100644 --- a/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts +++ b/airbyte-webapp/src/core/jsonSchema/schemaToYup.ts @@ -119,17 +119,17 @@ export const buildYupFormForJsonSchema = ( const hasDefault = isDefined(jsonSchema.default); if (hasDefault) { - // @ts-ignore can't infer correct type here so lets just use default from json_schema + // @ts-expect-error can't infer correct type here so lets just use default from json_schema schema = schema.default(jsonSchema.default); } if (!hasDefault && jsonSchema.const) { - // @ts-ignore can't infer correct type here so lets just use default from json_schema + // @ts-expect-error can't infer correct type here so lets just use default from json_schema schema = schema.oneOf([jsonSchema.const]).default(jsonSchema.const); } if (jsonSchema.enum) { - // @ts-ignore as enum is array we are going to use it as oneOf for yup + // @ts-expect-error as enum is array we are going to use it as oneOf for yup schema = schema.oneOf(jsonSchema.enum); } diff --git a/airbyte-webapp/src/core/request/AirbyteRequestService.ts b/airbyte-webapp/src/core/request/AirbyteRequestService.ts index 1bd8a3ee3797d..a0821a870560e 100644 --- a/airbyte-webapp/src/core/request/AirbyteRequestService.ts +++ b/airbyte-webapp/src/core/request/AirbyteRequestService.ts @@ -59,7 +59,7 @@ async function parseResponse(response: Response): Promise { return await response.json(); } - // @ts-ignore TODO: needs refactoring of services + // @ts-expect-error TODO: needs refactoring of services return response; } // eslint-disable-next-line @typescript-eslint/no-explicit-any diff --git a/airbyte-webapp/src/packages/cloud/views/auth/components/News.tsx b/airbyte-webapp/src/packages/cloud/views/auth/components/News.tsx index b96e3a57972d1..0fca51b134468 100644 --- a/airbyte-webapp/src/packages/cloud/views/auth/components/News.tsx +++ b/airbyte-webapp/src/packages/cloud/views/auth/components/News.tsx @@ -53,7 +53,6 @@ const News: React.FC = () => { - {/*@ts-ignore github icon fails here*/}

diff --git a/airbyte-webapp/src/views/layout/SideBar/components/SidebarPopout.tsx b/airbyte-webapp/src/views/layout/SideBar/components/SidebarPopout.tsx index b261acf380eeb..6bd93af12a3b1 100644 --- a/airbyte-webapp/src/views/layout/SideBar/components/SidebarPopout.tsx +++ b/airbyte-webapp/src/views/layout/SideBar/components/SidebarPopout.tsx @@ -56,7 +56,6 @@ const SidebarPopout: React.FC<{ label: ( - {/*@ts-ignore slack icon fails here*/}