Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Hubspot: engagements stream, remove auto-generated properties #9383

Closed
grubberr opened this issue Jan 10, 2022 · 0 comments · Fixed by #9385
Closed

🎉 Source Hubspot: engagements stream, remove auto-generated properties #9383

grubberr opened this issue Jan 10, 2022 · 0 comments · Fixed by #9385
Assignees
Labels
needs-triage type/bug Something isn't working

Comments

@grubberr
Copy link
Contributor

grubberr commented Jan 10, 2022

Environment

  • Airbyte version: example is 0.22.0-alpha
  • OS Version / Instance: example macOS, Windows 7/10, Ubuntu 18.04, GCP n2. , AWS EC2
  • Deployment: example are Docker or Kubernetes deploy env
  • Source Connector and version: (if applicable example Salesforce 0.2.3)
  • Destination Connector and version: (if applicable example Postgres 0.3.3)
  • Severity: Very Low / Low / Medium / High / Critical
  • Step where error happened: Deploy / Sync job / Setup new connection / Update connector / Upgrade Airbyte

Current Behavior

In current implementation we auto-generate schema with additional sub-object engagements.properties
but because engagements stream implemented with OLD legacy V1 API we don't need to do it.
properties sub-object has to be added only for streams generated using NEW V3 API.

Expected Behavior

We need to exclude properties sub-object from engagements stream.

Logs

If applicable, please upload the logs from the failing operation.
For sync jobs, you can download the full logs from the UI by going to the sync attempt page and
clicking the download logs button at the top right of the logs display window.

LOG

replace this with
your long log
output here

Steps to Reproduce

Are you willing to submit a PR?

Remove this with your answer.

@grubberr grubberr added type/bug Something isn't working needs-triage labels Jan 10, 2022
@grubberr grubberr self-assigned this Jan 10, 2022
@grubberr grubberr changed the title Source Hubspot: engagements stream, remove auto-generated properties Source Hubspot: engagements stream, remove auto-generated properties Jan 10, 2022
@grubberr grubberr changed the title Source Hubspot: engagements stream, remove auto-generated properties 🎉 Source Hubspot: engagements stream, remove auto-generated properties Jan 10, 2022
@grubberr grubberr moved this to Implementation in progress in GL Roadmap Jan 11, 2022
@grubberr grubberr moved this from Implementation in progress to Internal review in GL Roadmap Jan 11, 2022
@grubberr grubberr moved this from Internal review to Done in GL Roadmap Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage type/bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant