🐛 source mixpanel: hardcoded 'standard' properties for engage stream #7505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion error (particularly for 'browser_version')
|
|
github-actions
bot
added
area/connectors
|
/test connector=connectors/source-mixpanel
|
|
/test connector=connectors/source-mixpanel
|
bazarnov
requested changes
Oct 31, 2021
bazarnov
approved these changes
Nov 1, 2021
antixar
approved these changes
Nov 2, 2021
…ce-mixpanel-datatype-fix
sherifnada
approved these changes
Nov 2, 2021
| @@ -56,6 +56,7 @@ Select the correct region \(EU or US\) for your Mixpanel project. See detail [he | |||
|
|
|||
| | Version | Date | Pull Request | Subject | | |||
| | :--- | :--- | :--- | :--- | | |||
| | `0.1.2` | 2021-10-30 | [7505](https://github.com/airbytehq/airbyte/issues/6075) | Implemented 'standard' properties for engage stream | | |||
There was a problem hiding this comment.
Suggested change
| | `0.1.2` | 2021-10-30 | [7505](https://github.com/airbytehq/airbyte/issues/6075) | Implemented 'standard' properties for engage stream | | |
| | `0.1.2` | 2021-10-30 | [7505](https://github.com/airbytehq/airbyte/issues/6075) | Guarantee that standard and custom mixpanel properties in the `Engage` stream are written as strings | |
…ce-mixpanel-datatype-fix # Conflicts: # docs/integrations/sources/mixpanel.md
|
/publish connector=connectors/source-mixpanel
|
lmossman
pushed a commit
that referenced
this pull request
Nov 3, 2021
…7505) * Hardcoded 'standard' properties for engage stream to avoid normalization error (particularly for 'browser_version') * updated change log message * bumped connector version, updated change log * fix table in docs
16 tasks
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…irbytehq#7505) * Hardcoded 'standard' properties for engage stream to avoid normalization error (particularly for 'browser_version') * updated change log message * bumped connector version, updated change log * fix table in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 source mixpanel: hardcoded 'standard' properties for engage stream
What
Shortly about the problem.
Mixpanel 'engage' stream has dynamic schema. There are some 'standard' fields but users can create custom fields as well.
I have tried to create such 'custom' fields but there is no way to specify type for such custom field. I tried to create fields with different values: abc or 1. Such attrs are reported as string for me. I was not able to find any way to change this.
Customer has a problem with 'browser_version' field, which is a 'standard' field. It is reported as:
'number' - for customer
'string' - for our account.
Customer and I have similar values in this field, like "86.3.112.2", which is definitely a string.
So it is not clear what to do in this situation.
How
solution is: we can hard-code types for known 'standard' fields, but rely on API for another 'custom' fields. What do you think?
Recommended reading order
x.javay.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes