Source Stripe: upgrade connector doesn't allow save new config

[marcosmarxm]

Enviroment

• Airbyte version: 0.30.3-alpha
• OS Version / Instance: macOS
• Deployment: Docker
• Source Connector and version: Stripe 0.1.19
• Destination Connector and version: ~
• Severity: Very Low / Low / Medium / High / Critical
• Step where error happened: Update Config from existing connector

Current Behavior

I have a Stripe 0.1.19 connector and want to update to 0.1.20 where there is a new config field.
After upgrading the connector version and entered the connector config page I couldnt save the new config.

Stripe 0.1.19

Stripe 0.1.20 after change lookback windows variable to 30 doesnt allow me save!

Expected Behavior

Tell us what should happen.

Logs

If applicable, please upload the logs from the failing operation.
For sync jobs, you can download the full logs from the UI by going to the sync attempt page and
clicking the download logs button at the top right of the logs display window.

LOG

replace this with
your long log
output here

Steps to Reproduce

Are you willing to submit a PR?

Remove this with your answer.

[tuliren]

This looks like a universal problem. Should probably have higher priority.

[antixar]

I guess it is not relevant issue. We will check

[bazarnov]

@marcosmarxm

This issue is related to UI/UX. Once you've updated the source-stripe version from 0.1.19 to 0.1.20, the Save changes and test button is not active unless you Edit the Client_secret value. If you copy/paste the same secret value as it was before, the UI allows you to save the changes.
See the screenshots:

Before the update:
version = 0.1.19, no Lookback window field

After the update:
version = 0.1.20, Lookback window appeared, but Save changes and test button is not active

Once you re-edit the Client_secret with the same value as it was before the update (the same secret value), the Save changes and test button is active. Check the screen capture for more details.
https://user-images.githubusercontent.com/22987674/152775584-979e6b4b-8ad7-4fd1-a035-b257c35f63e4.mov

[misteryeo]

Tagging you in @timroes since this looks like a UI/UX issue

[jamakase]

We disable buttons only in a few cases: when the form is submitting, when there is some error, and when values don't differ from the initial one ( are not dirty ).

In this particular case, lookback_window_days has a default value, as a result, we assume that form values are the same as we apply 0 value by default here.

If some connector in the new version was upgraded and a new field was added, doesn't it mean that connector config value should be upgraded based on default values? So if we add lookback_window_days in new version and user upgrades connector - doesn't it mean that this property should be already applied? If yes - then it means we can't indeed update the form, as UI assumes it to be deeply equal.