Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Analytics: Support webflow Oauth #6173

Closed
sherifnada opened this issue Sep 17, 2021 · 0 comments · Fixed by #6306
Closed

Source Google Analytics: Support webflow Oauth #6173

sherifnada opened this issue Sep 17, 2021 · 0 comments · Fixed by #6306

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

We currently only support json_key authentication to Google Analytics. However, with the release of Airbyte Cloud, we need to start supporting Oauth, the more common way of authenticating to GA.

Instead of the current credentials_json field the GA config should accept one of:

  1. credentials_json
  2. oauth <-- this one should accept client_id, client_secret, and refresh token

This should be a oneof nested inside a top-level field called "auth_mechanism" . See the connector spec reference in the docs for reference on how this can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying the json key in the config's top-level should not be impacted by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants