Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *_ROOT_PARENT env variables #577

Closed
cgardens opened this issue Oct 15, 2020 · 2 comments
Closed

Remove *_ROOT_PARENT env variables #577

cgardens opened this issue Oct 15, 2020 · 2 comments
Labels
frozen Not being actively worked on team/platform-move type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Oct 15, 2020

Tell us about the problem you're trying to solve

We do not want developers to need to create all of the directory structure needed for airbyte to run. In order to do that we have hacked on HACK_WORKSPACE_ROOT_PARENT and HACK_LOCAL_ROOT_PARENT. The env variables must be parents of whatever WORKSPACE_ROOT and LOCAL_ROOT AND they must already exist on the local filesystem. This gives our docker compose a handle to create the needed directories that we want to use as mounts for our other services.

Describe the solution you’d like

This is obviously a pretty ugly hack and we would like to remove the need for env variables.

┆Issue is synchronized with this Asana task by Unito

@Amanraj0007
Copy link

Hi @cgardens
I am exploring docker deployment of airbyte and i encountered a service init which is creating /tmp/airbyte_local

which is getting mounted on server and worker's container.

what is significance of this directory. why do we need this ?

is it necessary to be created on host only where docker deamon is running? or we could create and mount from any filesystem services.

@bleonard bleonard added the frozen Not being actively worked on label Mar 22, 2024
@cgardens
Copy link
Contributor Author

no longer relevant with the upcoming deprecation of docker compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frozen Not being actively worked on team/platform-move type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants