Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide code coverage feedback in PRs #474

Closed
Tracked by #5961
sherifnada opened this issue Sep 30, 2020 · 3 comments
Closed
Tracked by #5961

Provide code coverage feedback in PRs #474

sherifnada opened this issue Sep 30, 2020 · 3 comments
Labels

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Sep 30, 2020

Tell us about the problem you're trying to solve

I would like to know the test coverage of my pull request or the master branch. #473 introduced basic code coverage, but I'd like to be able to see it in the branch I'm making changes to.

Describe the solution you’d like

Display a badge or report in each pull request which shows the code coverage of the code in that branch.

Additional context

codecov.io seems to be a leading tool in this regard.

┆Issue is synchronized with this Asana task by Unito

@davinchia
Copy link
Contributor

@jdpgrailsdev I believe this is already done?

@jdpgrailsdev
Copy link
Contributor

@jdpgrailsdev I believe this is already done?

@davinchia Not entirely, if I understand the ask in this ticket. The OSS code base does have the JaCoCo code coverage plugin applied to all projects and does generate coverage reports. It does not currently put a badge on the pull request to show the level of coverage. It does have the configuration to fail a build if a level of coverage is not met for any module, but that is a soft failure currently (it logs the lack of meeting the requirement, but does not fail the build). In summary, there is still some work to do to meet the problem statement in this issue, but some of the foundational work has been done.

@oustynova
Copy link

resolved within this task
#21376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants