Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring Facebook Marketing insights buffer days #2920

Closed
cgardens opened this issue Apr 16, 2021 · 1 comment · Fixed by #3396
Closed

Allow configuring Facebook Marketing insights buffer days #2920

cgardens opened this issue Apr 16, 2021 · 1 comment · Fixed by #3396
Assignees
@po3na4skld
Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Milestone
Connectors May 28...

Comments

@cgardens
Copy link
Contributor

cgardens commented Apr 16, 2021 •
edited by sherifnada
Loading

Tell us about the problem you're trying to solve

Today the Facebook marketing source always defaults to 28 for the buffer_days parameter. We want to make this configurable by the user. We should:

  • Add a parameter to spec.json called insights_lookback_window with the title Insights Lookback Window and an appropriate description that tells the user what this parameter controls. It should be an optional parameter.
  • This parameter should be used instead of 28 if the user has specified it.
@cgardens cgardens added type/enhancement New feature or request zazmic labels Apr 16, 2021
@cgardens cgardens added this to the Connectors April 16th, 2021 milestone Apr 16, 2021
@sherifnada sherifnada added the area/connectors Connector related issues label Apr 17, 2021
@sherifnada sherifnada removed this from the Connectors April 16th, 2021 milestone Apr 18, 2021
@sherifnada sherifnada changed the title Add configuration options to Facebook Source Allow configuring Facebook Marketing insights buffer days May 11, 2021
@sherifnada sherifnada added this to the Connectors May 14th 2021 milestone May 11, 2021
@po3na4skld
Copy link
Contributor

Hello @cgardens, what is the maximum value of insights_lookback_window should be?

@po3na4skld po3na4skld mentioned this issue May 13, 2021
Merged
2 tasks
@po3na4skld po3na4skld linked a pull request May 14, 2021 that will close this issue
🎉 Source Facebook Marketing: Allow configuring insights lookback window #3396
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@po3na4skld po3na4skld

Labels
area/connectors Connector related issues connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Projects
None yet
Milestone
Connectors May 28th, 2021
Development

Successfully merging a pull request may close this issue.

🎉 Source Facebook Marketing: Allow configuring insights lookback window airbytehq/airbyte
4 participants
@sherifnada @cgardens @karinakuz @po3na4skld