Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected field count to new streams table #21772

Closed
josephkmh opened this issue Jan 24, 2023 · 3 comments
Closed

Add selected field count to new streams table #21772

josephkmh opened this issue Jan 24, 2023 · 3 comments
Assignees
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@josephkmh
Copy link
Contributor

The number of selected fields in each stream should be displayed in a new column on the streams table:

Screenshot 2023-01-24 at 9 40 22 AM

Figma designs :https://www.figma.com/proto/liLQhcbpVHiEDW18kiXQe3/01_03_CONNECTIONS?node-id=972%3A36212&scaling=min-zoom&page-id=972%3A36208&starting-point-node-id=972%3A36212&show-proto-sidebar=1

The rest of the selection UI is being added in this PR: #21058

@edmundito
Copy link
Contributor

@dizel852 assigned this to you. You can work with @josephkmh to understand how column counts work. There is already some placeholder code in the table that can be uncommented as a starting point.

@dizel852
Copy link
Contributor

dizel852 commented Feb 27, 2023

@Upmitt
❓ A few questions:

  1. Is it a Pill button component? I see the same style as the Sync Mode dropdown has

image

image

  1. Does the counter should have the same styles as Sync Mode dropdown has for cases - changed(light blue background), removed(light blue background)

image

  1. If all fields are selected, do we need to show a counter like "10/10"?

image

@dizel852
Copy link
Contributor

Seems like I've found the answers 😅
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants