Airbyte Cron really does re-fetch new connector definitions every 30s

[evantahler]

Details in this thread 🧵

This PR seems to be the culprit #21073

Previously we had been instantiating a new RemoteDefinitionsProvider on each cron invocation, but now we're injecting the dependency so it's only ever instantiated once. Definitions are loaded from the remote source when instantiating the class, so in practice we only load the new values once, when cron boots. (diff)

A fix could be to change this back to instantiate on each call, or the right solution is probably to make fetching the catalog an explicit method call rather than only doing it on the constructor - this way it's more clear when the fetching happens.