Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-github has many timestamps as strings that should really be "date-time" #19298

Closed
evantahler opened this issue Nov 10, 2022 · 3 comments · Fixed by #19299
Closed

source-github has many timestamps as strings that should really be "date-time" #19298

evantahler opened this issue Nov 10, 2022 · 3 comments · Fixed by #19299

Comments

@evantahler
Copy link
Contributor

In source_github/schemas/events.json

  • created_at should gain "format": "date-time"

In source_github/schemas/workflow_runs.json

  • created_at should gain "format": "date-time"
  • updated_at should gain "format": "date-time"
@evantahler evantahler added type/bug Something isn't working needs-triage labels Nov 10, 2022
@evantahler evantahler changed the title source-github has many strings that should really be timestampe source-github has many timestamps as strings that should really be timestampe Nov 10, 2022
@evantahler evantahler changed the title source-github has many timestamps as strings that should really be timestampe source-github has many timestamps as strings that should really be "date-time" Nov 10, 2022
@evantahler
Copy link
Contributor Author

FYI @alex-gron

@alex-gron
Copy link
Contributor

@evantahler What does this mean for our existing Github connections? Will they continue to ingest timestamps as strings until we update the schema and/or trigger a reset?

@evantahler
Copy link
Contributor Author

@evantahler What does this mean for our existing Github connections? Will they continue to ingest timestamps as strings until we update the schema and/or trigger a reset?

Yep - things will remain as strings until (A) reset (B) we manually adjust the column type & values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants