Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notification Settings design #17087

Closed
edmundito opened this issue Sep 23, 2022 · 7 comments · Fixed by #18159
Closed

Update Notification Settings design #17087

edmundito opened this issue Sep 23, 2022 · 7 comments · Fixed by #18159
Assignees
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@edmundito
Copy link
Contributor

Update the design in the OSS notification settings page with Scenario #5 in the prototype:

https://www.figma.com/proto/SBtckxQGXX9V1jXLUgwRYp/01_02_NOTIFICATIONS?page-id=0%3A1&node-id=120%3A1522&viewport=865%2C929%2C0.15&scaling=min-zoom&starting-point-node-id=120%3A1812&show-proto-sidebar=1

  • Move the save button under the card
  • Leave the test button visible (and disable when webhooks is empty)
  • Improve documentation panel
  • Ensure switches are disabled when webhook is blank
@edmundito edmundito added area/frontend Related to the Airbyte webapp team/platform-move labels Sep 23, 2022
@matter-q matter-q self-assigned this Oct 7, 2022
@matter-q
Copy link
Contributor

matter-q commented Oct 11, 2022

@edmundito, where can I find documentation links?

image.png

@edmundito
Copy link
Contributor Author

Discussed with @matter-q on standup. Need to follow up with @Amruta-Ranade to create documentation. In the meantime, update and release page without the documentation panel.

@Amruta-Ranade
Copy link
Contributor

@edmundito Happy to help!

@edmundito
Copy link
Contributor Author

edmundito commented Oct 18, 2022

I followed up with @Amruta-Ranade on slack. It looks like we have a doc for this here:

https://docs.airbyte.com/operator-guides/configuring-sync-notifications/
And the video:
https://www.youtube.com/watch?v=NjYm8F-KiFc

@andyjih Can you confirm that these two cover what's intended in the design help?

@Amruta-Ranade
Copy link
Contributor

Note: The doc doesn't show up on our Docs sidebar nav yet. I need to investigate why and fix the issue. Waiting until we confirm that's the content we need

@andyjih
Copy link
Contributor

andyjih commented Oct 18, 2022

Confirming that those links are correct!

@Amruta-Ranade
Copy link
Contributor

Following up: We do have a new section in the updated docs for managing notifications: https://docs.airbyte.com/cloud/managing-airbyte-cloud#manage-airbyte-cloud-notifications
As a best practice, we refer users to official docs for third-party tools. I think that's still the right approach. Happy to chat if you have a differing opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants