Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in FB docs #1682

Closed
cgardens opened this issue Jan 16, 2021 · 3 comments · Fixed by #1699
Closed

Broken links in FB docs #1682

cgardens opened this issue Jan 16, 2021 · 3 comments · Fixed by #1699
Assignees
@eugene-kulak
Labels
type/bug Something isn't working
Milestone
Beta Launch

Comments

@cgardens
Copy link
Contributor

I deleted some links out of the facebook docs in this PR: #1681. The links were broken and causing the build to fail. Looks like when the FB source got updated (commit) some screenshots didn't get included in source. We should add those back so that the docs make sense.
@cgardens cgardens added type/bug Something isn't working zazmic labels Jan 16, 2021
@cgardens
Copy link
Contributor Author

heads up @sherifnada and @eugene-kulak

@eugene-kulak
Copy link
Contributor

eugene-kulak commented Jan 18, 2021 •
edited
Loading

it looks like the original FB connector had this issue as well, but it was fixed after I started my work on non-singer version, so no need to add any files, just to update the links.

@eugene-kulak
Copy link
Contributor

fixed in #1699

@cgardens cgardens mentioned this issue Jan 19, 2021
Merged
4 tasks
@cgardens cgardens added this to the Launch 1.0 milestone Jan 19, 2021
@sherifnada sherifnada removed their assignment Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-kulak eugene-kulak

Labels
type/bug Something isn't working
Projects
None yet
Milestone
Beta Launch
Development

Successfully merging a pull request may close this issue.

Source FB Marketing: add incremental support airbytehq/airbyte
3 participants
@sherifnada @cgardens @eugene-kulak