Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Amazon Ads: keep incremental sync for no records #15815

Closed
Tracked by #14686
grubberr opened this issue Aug 20, 2022 · 0 comments · Fixed by #15816
Closed
Tracked by #14686

🐛 Source Amazon Ads: keep incremental sync for no records #15815

grubberr opened this issue Aug 20, 2022 · 0 comments · Fixed by #15816
Assignees
@grubberr
Labels
needs-triage team/triage type/bug Something isn't working

Comments

@grubberr
Copy link
Contributor

grubberr commented Aug 20, 2022 •
edited
Loading

Current Behavior

Amazon Ads reporting streams can return no records.
In the current implementation if no records are received - STATE is not updated
and even for incremental sync, we can continue to sync from scratch again and again.

Expected Behavior

I propose to improve connector logic and updated STATE even if no records are received.
it means we read old dates only once and we will not re-read them again in subsequent sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grubberr grubberr

Labels
needs-triage team/triage type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Source Amazon Ads: move STATE inside report stream class airbytehq/airbyte
2 participants
@grubberr @octavia-squidington-iii