Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source MySQL should correctly map temporal types to JsonSchema #15381

Closed
edgao opened this issue Aug 5, 2022 · 4 comments · Fixed by #15504
Closed

Source MySQL should correctly map temporal types to JsonSchema #15381

edgao opened this issue Aug 5, 2022 · 4 comments · Fixed by #15504

Comments

@edgao
Copy link
Contributor

edgao commented Aug 5, 2022

Currently, source-mysql maps dates, datetimes, and timestamps to string. These should be mapped to date, timestamp_without_timezone, and timestamp_with_timezone respectively.

We should probably do #14628 first.

See e.g. https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSourceOperations.java#L182 (no explicit date/time handling, so they defaults to STRING) and tests (https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-mysql/src/test-integration/java/io/airbyte/integrations/source/mysql/AbstractMySqlSourceDatatypeTest.java#L237-L238)

@edgao
Copy link
Contributor Author

edgao commented Aug 5, 2022

this issue is a superset of #3865 (which only mentions DATETIME handling) and #10399 (which only covers DATEs).

@tuliren
Copy link
Contributor

tuliren commented Aug 9, 2022

Solution: copy what Postgres temporal processing logic to MySQL, and DRY the code if necessary.

@tuliren
Copy link
Contributor

tuliren commented Aug 9, 2022

Hey team! Please add your planning poker estimate with ZenHub @ryankfu @edgao @subodh1810 @rodireich

@tuliren
Copy link
Contributor

tuliren commented Aug 9, 2022

This issue is already covered in #14628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants