Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: Add incremental update #1478

Closed
3 tasks
eugene-kulak opened this issue Dec 29, 2020 · 1 comment · Fixed by #1699
Closed
3 tasks

Source Facebook Marketing: Add incremental update #1478

eugene-kulak opened this issue Dec 29, 2020 · 1 comment · Fixed by #1699
Assignees
@eugene-kulak
Labels
connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Milestone
Beta Launch

Comments

@eugene-kulak
Copy link
Contributor

eugene-kulak commented Dec 29, 2020 •
edited
Loading

Tell us about the problem you're trying to solve

Original singer tap (https://github.com/singer-io/tap-facebook) supports incremental update (bookmarks)

Describe the solution you’d like

Support save state and restore state for all streams

Describe the alternative you’ve considered or used

Using singer tap

Additional context

Add any other context or screenshots about the feature request here.

The estimation:

  • Implement passing filters to requests, get_state and set_state methods - 5h
  • Check if testing is possible with automated tests - 15m
  • Perform manual tests with each stream - 1h
    Dev Total: ~6h
@eugene-kulak eugene-kulak added the type/enhancement New feature or request label Dec 29, 2020
@eugene-kulak
Copy link
Contributor Author

blocked by #1443

@sherifnada sherifnada added this to the Launch 1.0 milestone Jan 19, 2021
@sherifnada sherifnada linked a pull request Jan 22, 2021 that will close this issue
Source FB Marketing: add incremental support #1699
Merged
4 tasks
@snyk-bot snyk-bot mentioned this issue Dec 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-kulak eugene-kulak

Labels
connectors/source/facebook-marketing connectors/sources-api type/enhancement New feature or request
Projects
None yet
Milestone
Beta Launch
Development

Successfully merging a pull request may close this issue.

Source FB Marketing: add incremental support airbytehq/airbyte
4 participants
@sherifnada @cgardens @karinakuz @eugene-kulak