Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present changes in catalog to the user #13329

Closed
timroes opened this issue May 31, 2022 · 2 comments · Fixed by #14074
Closed

Present changes in catalog to the user #13329

timroes opened this issue May 31, 2022 · 2 comments · Fixed by #14074
Assignees
Labels
area/frontend Related to the Airbyte webapp

Comments

@timroes
Copy link
Contributor

timroes commented May 31, 2022

When a user uses the "Refresh catalogue" functionality on an existing saved connection, we want to show a modal containing the changes in the catalog that the user need to confirm.

The backend API for this is tracked in #13232

Figma mocks:https://www.figma.com/proto/liLQhcbpVHiEDW18kiXQe3/01_03_CONNECTIONS?scaling=min-zoom&page-id=1%3A3&node-id=198%3A3822&starting-point-node-id=112%3A320
^ updated figma link 6/22

The behavior should be as follows:

  • The user presses the refresh button, which would do a request towards the web_backend/connections/get endpoint, which will return the diff format outlined in the BE issue
  • If there is a diff available, the FE will show a modal with just a confirm dialog as shown in the designs. The confirm button will only hide the modal. There is no further BE calls happening.
  • The modal currently showing the saving the connection should no longer be shown.
  • Should still send the full catalog to the backend
@timroes timroes added area/frontend area/frontend Related to the Airbyte webapp labels May 31, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson
Copy link
Contributor

Bug discovered while working on this: we should improve error handling if the schema refresh fails
#14096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants