Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The publish command no longer works for private docker repository #12584

Closed
tuliren opened this issue May 4, 2022 · 4 comments · Fixed by #13141
Closed

The publish command no longer works for private docker repository #12584

tuliren opened this issue May 4, 2022 · 4 comments · Fixed by #13141
Assignees
Labels
type/bug Something isn't working

Comments

@tuliren
Copy link
Contributor

tuliren commented May 4, 2022

Current Behavior

Expected Behavior

  • The publish command should work for private connectors as well.

Logs

https://github.com/airbytehq/airbyte/runs/6294841743?check_suite_focus=true

+ TAG_URL=https://hub.docker.com/v2/repositories/airbyte/destination-databricks/tags/0.1.5
++ curl --silent --output /dev/null --write-out '%***http_code***' https://hub.docker.com/v2/repositories/airbyte/destination-databricks/tags/0.1.5
+ DOCKERHUB_RESPONSE_CODE=404
+ [[ 404 == \4\0\4 ]]
+ echo 'Tag 0.1.5 was not registered on DockerHub for image airbyte/destination-databricks, please try to bump the version again.'
+ exit 1
Tag 0.1.5 was not registered on DockerHub for image airbyte/destination-databricks, please try to bump the version again.
Error: Process completed with exit code 1.

Potential Solution

  • Solution 1. Use a URL that works for private repositories as well.
  • Solution 2. Add a skip-tag-check parameter to bypass the tag check.
@noahkawasaki-airbyte
Copy link
Contributor

noahkawasaki-airbyte commented May 24, 2022

Hey @tuliren I'm looking into this and it seems to work for Databricks now, was databricks moved to public repo that you know of? I feel like since we docker login even a private repo should still work. I wonder if the databricks tag was not registered quickly enough and maybe adding a retry into this http call would fix

@noahkawasaki-airbyte
Copy link
Contributor

Nvm I see its public now, ill do some testing

@noahkawasaki-airbyte
Copy link
Contributor

#13141

Got it working, will tag for review later when its confirmed in CI

@tuliren
Copy link
Contributor Author

tuliren commented May 26, 2022

Yes, Databricks is public now. So this is no longer a problem for Databricks. But still appreciate your patch for other private repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants