Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Java CDK to emit AirbyteTraceMessage #12471

Closed
7 tasks done
Tracked by #12322
pedroslopez opened this issue Apr 29, 2022 · 3 comments · Fixed by #12614
Closed
7 tasks done
Tracked by #12322

Update the Java CDK to emit AirbyteTraceMessage #12471

pedroslopez opened this issue Apr 29, 2022 · 3 comments · Fixed by #12614
Assignees

Comments

@pedroslopez
Copy link
Contributor

pedroslopez commented Apr 29, 2022

Full context in parent issue #12322
Java connectors should emit AirbyteTraceMessage with error information when something goes wrong.

Scope / acceptance criteria:

  • Implement java utility for AirbyteTraceMessage
  • Implement a naive exception catch across java connectors so we can log the new AirbyteTraceMessage
    • We should propagate any existing error information up as part of this AirbyteTraceMessage, i.e. this change shouldn’t regress error usefulness.
    • To be forward compatible, check if we're catching an AirbyteTraceMessage and if so throw as is (don't naively catch)
  • Write necessary tests
  • Add docs to explain usage to developers
  • Version bump and publish current GA java connectors
    • this will start populating filled-out FailureReasons to work with for reporting purposes e.g. for building incident management.

Not in Scope:

  • Adding specific AirbyteTraceMessage errors to individual connectors
  • Adding specific AirbyteTraceMessage errors to base/abstract connectors (e.g. JDBC)
  • Implementing related testing (separate issue for that).
@pedroslopez pedroslopez changed the title Update the Java CDK to emit <code class="notranslate">AirbyteTraceMessage` Update the Java CDK to emit AirbyteTraceMessage Apr 29, 2022
@Phlair Phlair self-assigned this Apr 29, 2022
@Phlair
Copy link
Contributor

Phlair commented May 3, 2022

Open Qs: Where do we do the naive catch?

  • IntegrationRunner looks like a good contender
  • Depending on the answer to this, it may become necessary to bump and publish connectors to actually implement the naive try/catch. Is that in scope?

@grishick
Copy link
Contributor

@Phlair once you are done with this, could you please guide @mkhokh-33 to correctly use the new AirbyteTraceMessage in this issue

@Phlair
Copy link
Contributor

Phlair commented May 10, 2022

@grishick absolutely, will do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants