Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Specs] Scheduler V2 Job Retention Cron. #11869

Closed
davinchia opened this issue Apr 10, 2022 · 10 comments
Closed

[Specs] Scheduler V2 Job Retention Cron. #11869

davinchia opened this issue Apr 10, 2022 · 10 comments

Comments

@davinchia
Copy link
Contributor

davinchia commented Apr 10, 2022

Tell us about the problem you're trying to solve

Scheduler V1 includes job history purging to minimise DB usage. Scheduler V2 is done with Temporal and there is currently no job sweeping available.

We need to figure out how to sweep jobs as Scheduler V2 gets stabilised and released to OSS. This is also important for Cloud to minimise cost.

Describe the solution you’d like

The eventual solution should:

  • be compatible across Docker and Kube.
  • be usable in both OSS and Cloud.
  • allow for sane sweeping configuration probably centered around days.

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

Add any other context or screenshots about the feature request here.

Are you willing to submit a PR?

Remove this with your answer :-)

@davinchia
Copy link
Contributor Author

fyi @benmoriceau and @cgardens

@davinchia davinchia changed the title Scheduler V2 Job Retention Jobs. Scheduler V2 Job Retention Cron. Apr 10, 2022
@benmoriceau
Copy link
Contributor

@davinchia I tagged it as a spec issue and will try to make it to be in the next sprint. Do you know if there is some legal duration which we need to respect in order to define the priority of this ticket.

@benmoriceau benmoriceau changed the title Scheduler V2 Job Retention Cron. [Specs] Scheduler V2 Job Retention Cron. Apr 12, 2022
@jrhizor
Copy link
Contributor

jrhizor commented Apr 12, 2022

Looks like the likely solution here is to use Temporal (either as a scheduled Temporal cron that cleans up for all jobs or something that cleans up for a connection itself after each run).

@davinchia
Copy link
Contributor Author

davinchia commented Apr 13, 2022

@benmoriceau no legal requirements for now. We've historically do so for operational/cost reasons.

@nataliekwong @bmcgilli are either of you aware of any legal requirements to keep data/are there product requirements around there that have surfaced since we last discussed this?

fyi @andyjih.

@nataliekwong
Copy link
Contributor

I'm not aware of any.

@bmcgilli
Copy link
Contributor

What's changing? Previously there was no concern from our legal council.

Also with Patsy starting in 2 weeks we can have her flag anything legal-related as she onboards

@benmoriceau
Copy link
Contributor

It will be about fixing a regression. We had a sweeping of the old logs and DB in order to save cost which hasn't been added with the scheduler v2. We need to re-introduce it. I wonder if we promised to our clients that we will keeps logs up to X days/months

@davinchia
Copy link
Contributor Author

@benmoriceau sounds like there are no new reqs. I think using the default of sweeping after 60 days is good enough for now.

@cgardens
Copy link
Contributor

Context: For the cloud product we will want to hold logs for 1 year for security compliance reasons.

@davinchia
Copy link
Contributor Author

This is out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants