Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK: patch time.sleep in unit tests to avoid actual sleeps #11784

Closed
sherifnada opened this issue Apr 7, 2022 · 0 comments
Closed

CDK: patch time.sleep in unit tests to avoid actual sleeps #11784

sherifnada opened this issue Apr 7, 2022 · 0 comments
Assignees
@brianjlai
Labels
CDK Connector Development Kit team/extensibility type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Apr 7, 2022 •
edited by sync-by-unito bot
Loading

Tell us about the problem you're trying to solve

We waste a bunch of time in unit tests on sleeps. We should use mocker.patch(time.sleep) in the CDK tests to skip actual sleeps.

See an example here.

Describe the solution you’d like

unit tests don't actually sleep

┆Issue is synchronized with this Monday item by Unito
@sherifnada sherifnada added type/enhancement New feature or request good first issue CDK Connector Development Kit labels Apr 7, 2022
@sherifnada sherifnada moved this to Non-groomed backlog in API Sources DX Roadmap Apr 7, 2022
@sherifnada sherifnada moved this from Non-groomed backlog to Groomed Backlog in API Sources DX Roadmap Apr 7, 2022
@girarda girarda assigned girarda and brianjlai and unassigned girarda Apr 8, 2022
@sherifnada sherifnada moved this from Groomed Backlog to Ready for implementation (current sprint) in API Sources DX Roadmap Apr 14, 2022
@shyngysnurzhan shyngysnurzhan mentioned this issue Apr 15, 2022
Merged
@brianjlai brianjlai mentioned this issue Apr 26, 2022
Merged
14 tasks
Repository owner moved this from Ready for implementation (current sprint) to Done in API Sources DX Roadmap Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianjlai brianjlai

Labels
CDK Connector Development Kit team/extensibility type/enhancement New feature or request
Projects
API Sources DX Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bleonard @girarda @sherifnada @brianjlai