Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resource limits for a connector definition #10295

Closed
cgardens opened this issue Feb 12, 2022 · 1 comment · Fixed by #10483
Closed

Set resource limits for a connector definition #10295

cgardens opened this issue Feb 12, 2022 · 1 comment · Fixed by #10483
Assignees
Labels

Comments

@cgardens
Copy link
Contributor

cgardens commented Feb 12, 2022

Tell us about the problem you're trying to solve

Since connectors now respect resource limits (when configured), we want to be able to tune those resource limits by connector. For example, we want there to be a default resource limit for connectors that is relatively low (~200-300MB), but some connectors, we want to allow to use more resource. e.g pokeapi source uses very little memory, while in many cases the bigquery destination needs more.

Describe the solution you’d like

Add the ability to set resource limits at the connector definition level.

Execution:

  • add this to the actor_definitions table
  • pipe it through to the worker
  • add it to the api (in the future we can add it in the UI)

Note: After this change, there will be 3 places connector resources can be set. As an environment variable (worker configs), for a connector definition and for a connection. We should respect the limits in this order: connection > connector definition > worker configs.

Acceptance Criteria

  • As an airbyter engineer, I am able to set the resources limits (cpu and memory) for a connector definition via API and the DB directly.
  • This configuration should override the default connector resource limits but resource limits specified at the connection leve.
@cgardens cgardens added type/enhancement New feature or request P0 labels Feb 12, 2022
@pmossman
Copy link
Contributor

Backlog Grooming notes:

  • worker that is running should just use whatever the appropriate resource limit according to the hierarchy
  • we won't require this to be set for a connector definition (at least to start with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants