From b8534038fdf2fad25bdb60d6d15bcd00278eb0db Mon Sep 17 00:00:00 2001 From: "Sherif A. Nada" Date: Fri, 28 May 2021 15:10:02 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9BSource=20Stripe=20bugfix:=20Update?= =?UTF-8?q?=20stripe=20data=20types=20to=20output=20number=20instead=20of?= =?UTF-8?q?=20int=20(#3728)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For some reason a lot of integer fields are being output as `.0` which breaks normalization. This is also happening in other sources, Shopify and Recurly. We need to root cause this issue or roll out a wider fix, perhaps using the CDK. For now, we're just trying to unblock the user. --- .../e094cb9a-26de-4645-8761-65c0c425d1de.json | 2 +- .../src/main/resources/seed/source_definitions.yaml | 2 +- .../connectors/source-stripe/Dockerfile | 2 +- .../source_stripe/schemas/invoices.json | 12 ++++++------ .../source_stripe/schemas/subscriptions.json | 12 ++++++------ 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json b/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json index f9dc14446a4d7..c6dae810f8aca 100644 --- a/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json +++ b/airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e094cb9a-26de-4645-8761-65c0c425d1de.json @@ -2,7 +2,7 @@ "sourceDefinitionId": "e094cb9a-26de-4645-8761-65c0c425d1de", "name": "Stripe", "dockerRepository": "airbyte/source-stripe", - "dockerImageTag": "0.1.9", + "dockerImageTag": "0.1.10", "documentationUrl": "https://hub.docker.com/r/airbyte/source-stripe", "icon": "stripe.svg" } diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index ef6e9f47d2257..53492858d49fa 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -78,7 +78,7 @@ - sourceDefinitionId: e094cb9a-26de-4645-8761-65c0c425d1de name: Stripe dockerRepository: airbyte/source-stripe - dockerImageTag: 0.1.9 + dockerImageTag: 0.1.10 documentationUrl: https://hub.docker.com/r/airbyte/source-stripe icon: stripe.svg - sourceDefinitionId: b03a9f3e-22a5-11eb-adc1-0242ac120002 diff --git a/airbyte-integrations/connectors/source-stripe/Dockerfile b/airbyte-integrations/connectors/source-stripe/Dockerfile index 70daaad168032..3c9cd081a37af 100644 --- a/airbyte-integrations/connectors/source-stripe/Dockerfile +++ b/airbyte-integrations/connectors/source-stripe/Dockerfile @@ -11,5 +11,5 @@ RUN pip install . ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.9 +LABEL io.airbyte.version=0.1.10 LABEL io.airbyte.name=airbyte/source-stripe diff --git a/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json b/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json index f1d38ca982bca..bb181afd2d05e 100644 --- a/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json +++ b/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/invoices.json @@ -90,20 +90,20 @@ "type": ["null", "boolean"] }, "amount_off": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "redeem_by": { "type": ["null", "string"], "format": "date-time" }, "duration_in_months": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "percent_off_precise": { "type": ["null", "number"] }, "max_redemptions": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "currency": { "type": ["null", "string"] @@ -112,7 +112,7 @@ "type": ["null", "string"] }, "times_redeemed": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "id": { "type": ["null", "string"] @@ -124,10 +124,10 @@ "type": ["null", "string"] }, "percent_off": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "created": { - "type": ["null", "integer"] + "type": ["null", "number"] } } }, diff --git a/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/subscriptions.json b/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/subscriptions.json index 79ae343c07495..085a986b3614c 100644 --- a/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/subscriptions.json +++ b/airbyte-integrations/connectors/source-stripe/source_stripe/schemas/subscriptions.json @@ -63,20 +63,20 @@ "type": ["null", "boolean"] }, "amount_off": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "redeem_by": { "type": ["null", "string"], "format": "date-time" }, "duration_in_months": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "percent_off_precise": { "type": ["null", "number"] }, "max_redemptions": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "currency": { "type": ["null", "string"] @@ -85,7 +85,7 @@ "type": ["null", "string"] }, "times_redeemed": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "id": { "type": ["null", "string"] @@ -97,10 +97,10 @@ "type": ["null", "string"] }, "percent_off": { - "type": ["null", "integer"] + "type": ["null", "number"] }, "created": { - "type": ["null", "integer"] + "type": ["null", "number"] } } },