From 64f127f33cd692a30bed910ad13f52587cfe2021 Mon Sep 17 00:00:00 2001 From: Marcos Marx Date: Sat, 15 Jan 2022 16:24:38 -0300 Subject: [PATCH] Destination Snowflake: correct files and format (#9529) --- .../destination/s3/S3DestinationConfig.java | 14 +++++++------- .../snowflake/SnowflakeDestinationTest.java | 9 --------- .../src/test/resources/insert_config.json | 2 +- 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/airbyte-integrations/connectors/destination-s3/src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java b/airbyte-integrations/connectors/destination-s3/src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java index 79ea47bee1853..626aa9eb63869 100644 --- a/airbyte-integrations/connectors/destination-s3/src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java +++ b/airbyte-integrations/connectors/destination-s3/src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java @@ -4,11 +4,11 @@ package io.airbyte.integrations.destination.s3; -import com.amazonaws.auth.InstanceProfileCredentialsProvider; import com.amazonaws.ClientConfiguration; import com.amazonaws.auth.AWSCredentials; import com.amazonaws.auth.AWSStaticCredentialsProvider; import com.amazonaws.auth.BasicAWSCredentials; +import com.amazonaws.auth.InstanceProfileCredentialsProvider; import com.amazonaws.client.builder.AwsClientBuilder; import com.amazonaws.services.s3.AmazonS3; import com.amazonaws.services.s3.AmazonS3ClientBuilder; @@ -129,17 +129,17 @@ public S3FormatConfig getFormatConfig() { public AmazonS3 getS3Client() { final AWSCredentials awsCreds = new BasicAWSCredentials(accessKeyId, secretAccessKey); - if (accessKeyId.isEmpty() && !secretAccessKey.isEmpty() - || !accessKeyId.isEmpty() && secretAccessKey.isEmpty()) { + if (accessKeyId.isEmpty() && !secretAccessKey.isEmpty() + || !accessKeyId.isEmpty() && secretAccessKey.isEmpty()) { throw new RuntimeException("Either both accessKeyId and secretAccessKey should be provided, or neither"); } if (accessKeyId.isEmpty() && secretAccessKey.isEmpty()) { return AmazonS3ClientBuilder.standard() - .withCredentials(new InstanceProfileCredentialsProvider(false)) - .build(); - } - + .withCredentials(new InstanceProfileCredentialsProvider(false)) + .build(); + } + else if (endpoint == null || endpoint.isEmpty()) { return AmazonS3ClientBuilder.standard() .withCredentials(new AWSStaticCredentialsProvider(awsCreds)) diff --git a/airbyte-integrations/connectors/destination-snowflake/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java b/airbyte-integrations/connectors/destination-snowflake/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java index 8125613834c00..74cb73490d5ba 100644 --- a/airbyte-integrations/connectors/destination-snowflake/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java +++ b/airbyte-integrations/connectors/destination-snowflake/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java @@ -11,14 +11,12 @@ import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.collect.ImmutableMap; -import io.airbyte.commons.io.IOs; import io.airbyte.commons.jackson.MoreMappers; import io.airbyte.commons.json.Jsons; import io.airbyte.commons.resources.MoreResources; import io.airbyte.db.jdbc.JdbcDatabase; import io.airbyte.integrations.base.AirbyteMessageConsumer; import io.airbyte.integrations.base.Destination; -<<<<<<< HEAD import io.airbyte.protocol.models.AirbyteMessage; import io.airbyte.protocol.models.AirbyteRecordMessage; import io.airbyte.protocol.models.CatalogHelpers; @@ -26,13 +24,6 @@ import io.airbyte.protocol.models.DestinationSyncMode; import io.airbyte.protocol.models.Field; import io.airbyte.protocol.models.JsonSchemaPrimitive; -======= -import io.airbyte.protocol.models.*; -import org.junit.jupiter.api.DisplayName; -import org.junit.jupiter.api.Test; - ->>>>>>> master -import java.nio.file.Path; import java.sql.SQLException; import java.time.Instant; import java.util.List; diff --git a/airbyte-integrations/connectors/destination-snowflake/src/test/resources/insert_config.json b/airbyte-integrations/connectors/destination-snowflake/src/test/resources/insert_config.json index 44d984364cb48..6f5ec2e7c8a80 100644 --- a/airbyte-integrations/connectors/destination-snowflake/src/test/resources/insert_config.json +++ b/airbyte-integrations/connectors/destination-snowflake/src/test/resources/insert_config.json @@ -6,4 +6,4 @@ "schema": "AIRBYTE_SCHEMA", "username": "AIRBYTE_INTEGRATION_TEST", "password": "testPass" -} \ No newline at end of file +}