Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonschema dependency to >= 4.18.0 #231

Open
ogreyard opened this issue Jan 19, 2025 · 4 comments
Open

Update jsonschema dependency to >= 4.18.0 #231

ogreyard opened this issue Jan 19, 2025 · 4 comments

Comments

@ogreyard
Copy link

I'd like to try the demo with pyairbyte within jupyterlab.
When installing the airbyte library, jsonschema is downgraded to 4.17.x
The more recent versions of jupyterlab require jsonschema>=4.18.0
Is there any chance you may update jsonschema to 4.18.x soon?

@pushrbx
Copy link

pushrbx commented Feb 20, 2025

Does anyone plan to do the upgrade, or is it on the roadmap for the maintainers? I would give it a shot. I'm guessing I just need to replace all RefResolver occurrences with the referencing library and change the tests.

@jscheel
Copy link

jscheel commented Feb 24, 2025

Yeah, I think this is a pretty important one. jsonschema 4.18.x was release in July 2023. Lots package dependency problems are caused by pinning to such an old dependency. Is there any evidence that the 4.18.x change was BC-breaking for airbyte-python-cdk? The release notes say that 4.18.x should be backwards compatible, save deprecation warnings.

@jscheel
Copy link

jscheel commented Feb 27, 2025

Working on this here when I have a chance: https://github.com/jscheel/airbyte-python-cdk/pull/1/files

@natikgadzhi
Copy link
Contributor

We will also get to this, and I’d be happy to support folks who are trying to update it now.

We have a project that would change how we work with manifest component schema in the next 2 months. It could be good time to do this as an infra layer change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants