Skip to content

Commit 192e905

Browse files
committed
chore: pr review and cleanup
1 parent d7d1fda commit 192e905

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

airbyte_cdk/sources/declarative/decoders/noop_decoder.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class NoopDecoder(Decoder):
1414
def is_stream_response(self) -> bool:
1515
return False
1616

17-
def decode( # type: ignore[override]
17+
def decode( # type: ignore[override] # Signature doesn't match base class
1818
self,
1919
response: requests.Response,
2020
) -> Generator[Mapping[str, Any], None, None]:

airbyte_cdk/sources/file_based/availability_strategy/abstract_file_based_availability_strategy.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
class AbstractFileBasedAvailabilityStrategy(AvailabilityStrategy):
2626
@abstractmethod
27-
def check_availability( # type: ignore[override]
27+
def check_availability( # type: ignore[override] # Signature doesn't match base class
2828
self,
2929
stream: Stream,
3030
logger: logging.Logger,

airbyte_cdk/sources/file_based/availability_strategy/default_file_based_availability_strategy.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class DefaultFileBasedAvailabilityStrategy(AbstractFileBasedAvailabilityStrategy
3030
def __init__(self, stream_reader: AbstractFileBasedStreamReader) -> None:
3131
self.stream_reader = stream_reader
3232

33-
def check_availability( # type: ignore[override]
33+
def check_availability( # type: ignore[override] # Signature doesn't match base class
3434
self,
3535
stream: AbstractFileBasedStream,
3636
logger: logging.Logger,

airbyte_cdk/sources/streams/http/requests_native_auth/oauth.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ def get_access_token(self) -> str:
293293
emit_configuration_as_airbyte_control_message(self._connector_config)
294294
return self.access_token
295295

296-
def refresh_access_token( # type: ignore[override]
296+
def refresh_access_token( # type: ignore[override] # Signature doesn't match base class
297297
self,
298298
) -> Tuple[str, str, str]:
299299
response_json = self._get_refresh_access_token_response()

pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ pytest-cov = "*"
9898
pytest-httpserver = "*"
9999
pytest-mock = "*"
100100
requests-mock = "*"
101+
# Stubs packages for mypy typing
101102
types-requests = "^2.32.0.20241016"
102103
types-python-dateutil = "^2.9.0.20241003"
103104
types-pyyaml = "^6.0.12.20240917"

0 commit comments

Comments
 (0)