Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fastclick #377

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Disable fastclick #377

merged 1 commit into from
Mar 17, 2017

Conversation

moonboots
Copy link
Collaborator

to: @majapw

This is kind of a terrible way to work around a fastclick issue affecting our implementation. Let me know if you think it would be less terrible as a prop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.1%) to 87.322% when pulling ff50a18 on moonboots:disable-fastclick into f70be5e on airbnb:master.

@majapw
Copy link
Collaborator

majapw commented Mar 17, 2017

@moonboots is this adding a class that does something base on some CSS existing ... in our codebase? Why not add the actual CSS here? This seems v. strange.

@moonboots
Copy link
Collaborator Author

Unfortunately, disabling fastclick on parts of the page requires adding this needsclick class. We don't reference this class in css.

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. My. God. That's their solution??? Is this what the internet was like four years ago???

U.U All right. Guess that's what we're doing.

Also, was coverage just broken?

@majapw majapw merged commit eec702a into react-dates:master Mar 17, 2017
@moonboots moonboots deleted the disable-fastclick branch March 17, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants