Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http.route tag (and span naming) if possible #115

Closed
codefromthecrypt opened this issue Feb 26, 2018 · 3 comments
Closed

Support http.route tag (and span naming) if possible #115

codefromthecrypt opened this issue Feb 26, 2018 · 3 comments

Comments

@codefromthecrypt
Copy link

The "http.route" tag indicates a route expression like /users/:userId that corresponded with an http request. I'm not sure the aio framework has routing language or not, but if so, it will be nice.

https://zipkin.io/public/thrift/v1/zipkinCore.html#Const_HTTP_ROUTE

Note: the naming expression you use is the same as Brave, except it now uses templates and keywords for redirect or not found

openzipkin/brave#602

@jettify
Copy link
Member

jettify commented Mar 3, 2018

There is language for routine like:
/foo/bar/{name}
foo/bar/
r/foo/bar/{name:\d+}
I just have not found good API to retrieve it, may be I missed something.

@jettify
Copy link
Member

jettify commented Mar 3, 2018

@asvetlov can you point me into right direction? For now I do not see better way than request.match_info.route.get_info()['formatter'])

@jettify
Copy link
Member

jettify commented Apr 30, 2018

As discussed special route should appear in aiohttp first aio-libs/aiohttp#2968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants