-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
replace deprecated asyncio.iscoroutinefunction with inspect.iscoroutinefunction #10473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for raising the issue! |
Note that those functions are not equivalent, so there may be some issues migrating. |
I've not investigated enough to figure out if that's deliberate or a CPython bug that should be fixed.. |
I looked at the linked aio-libs/async-lru#637, the fix for that is to call |
I can't seem to get that to work. Think you could create a PR? |
Nevermind, put it in the wrong place. Sorted now. |
Describe the bug
Python 3.14 deprecates
asyncio.iscoroutinefunction
in favor ofinspect.iscoroutinefunction
and aiohttp at some places uses the deprecated name so it should be changed to newerinspect.iscoroutinefunction
.To Reproduce
Run aiohttp tests on 3.14 to see the warnings.
Expected behavior
No warnings reported
Logs/tracebacks
Python Version
aiohttp Version
$ python -m pip show aiohttp
multidict Version
$ python -m pip show multidict
propcache Version
$ python -m pip show propcache
yarl Version
$ python -m pip show yarl
OS
Linux
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: