Conform to RFC3986 - do not include url fragments in requests (#1174)

* do not include url fragments in requests

* Added myself to CONTRIBUTORS.txt and filed a new entry to CHANGES.rst

Author: bmuller

CHANGES.rst

@@ -131,7 +131,7 @@ CHANGES
 - `aiohttp.TCPConnector` uses asynchronous DNS resolver if available by
   default #1152
 
--
+- Conform to RFC3986 - do not include url fragments in client requests #1174
 
 -
 

CONTRIBUTORS.txt

@@ -26,6 +26,7 @@ Ben Bader
 Benedikt Reinartz
 Brett Cannon
 Brian C. Lane
+Brian Muller
 Boris Feld
 Carl George
 Chien-Wei Huang
@@ -133,4 +134,4 @@ Yusuke Tsutsumi
 Марк Коренберг
 Семён Марьясин
 Pau Freixes
-Alexey Firsov
+Alexey Firsov

aiohttp/client.py

@@ -181,6 +181,7 @@ def _request(self, method, url, *,
                 skip_headers.add(istr(i))
 
         while True:
+            url, _ = urllib.parse.urldefrag(url)
 
             cookies = self._cookie_jar.filter_cookies(url)
 

tests/test_client_functional.py

@@ -374,6 +374,45 @@ def handler_ok(request):
         yield from resp.release()
 
 
+@asyncio.coroutine
+def test_drop_fragment_on_redirect(create_app_and_client):
+    @asyncio.coroutine
+    def handler_redirect(request):
+        return web.Response(status=301, headers={'Location': '/ok#fragment'})
+
+    @asyncio.coroutine
+    def handler_ok(request):
+        return web.Response(status=200)
+
+    app, client = yield from create_app_and_client()
+    app.router.add_route('GET', '/ok', handler_ok)
+    app.router.add_route('GET', '/redirect', handler_redirect)
+
+    resp = yield from client.get('/redirect')
+    try:
+        assert resp.status == 200
+        assert resp.url.endswith('/ok')
+    finally:
+        yield from resp.release()
+
+
+@asyncio.coroutine
+def test_drop_fragment(create_app_and_client):
+    @asyncio.coroutine
+    def handler_ok(request):
+        return web.Response(status=200)
+
+    app, client = yield from create_app_and_client()
+    app.router.add_route('GET', '/ok', handler_ok)
+
+    resp = yield from client.get('/ok#fragment')
+    try:
+        assert resp.status == 200
+        assert resp.url.endswith('/ok')
+    finally:
+        yield from resp.release()
+
+
 @asyncio.coroutine
 def test_history(create_app_and_client):
     @asyncio.coroutine