Web protocol cleanup (#2500)

* Drop deprecated slow_request_timeout param

* Drop **kwargs eager devourer from web protocol

* Drop slow_request_timeout from docs

* Add changelog

Author: asvetlov

CHANGES/2500.removal

@@ -0,0 +1,2 @@
+Drop deprecated `slow_request_timeout` param and `**kwargs`` from
+`RequestHandler`.

aiohttp/web_protocol.py

@@ -3,7 +3,6 @@
 import http.server
 import socket
 import traceback
-import warnings
 from collections import deque
 from contextlib import suppress
 from html import escape as html_escape
@@ -84,7 +83,6 @@ class RequestHandler(asyncio.streams.FlowControlMixin, asyncio.Protocol):
     def __init__(self, manager, *, loop=None,
                  keepalive_timeout=75,  # NGINX default value is 75 secs
                  tcp_keepalive=True,
-                 slow_request_timeout=None,
                  logger=server_logger,
                  access_log_class=helpers.AccessLogger,
                  access_log=access_logger,
@@ -94,11 +92,7 @@ def __init__(self, manager, *, loop=None,
                  max_headers=32768,
                  max_field_size=8190,
                  lingering_time=10.0,
-                 max_concurrent_handlers=1,
-                 **kwargs):
-        if slow_request_timeout is not None:
-            warnings.warn(
-                'slow_request_timeout is deprecated', DeprecationWarning)
+                 max_concurrent_handlers=1):
 
         super().__init__(loop=loop)
 

docs/web_reference.rst

@@ -1330,7 +1330,6 @@ duplicated like one using :meth:`Application.copy`.
     :param bool tcp_keepalive: Enable TCP Keep-Alive. Default: ``True``.
     :param int keepalive_timeout: Number of seconds before closing Keep-Alive
       connection. Default: ``75`` seconds (NGINX's default value).
-    :param slow_request_timeout: Slow request timeout. Default: ``0``.
     :param logger: Custom logger object. Default:
       :data:`aiohttp.log.server_logger`.
     :param access_log: Custom logging object. Default:

tests/test_web_protocol.py

@@ -253,11 +253,6 @@ def test_srv_keep_alive(srv):
     assert not srv._keepalive
 
 
-def test_slow_request(make_srv):
-    with pytest.warns(DeprecationWarning):
-        make_srv(slow_request_timeout=0.01)
-
-
 async def test_simple(srv, loop, buf):
     srv.data_received(
         b'GET / HTTP/1.1\r\n\r\n')