Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Transport commit is creating issue to init repo #3109

Closed
Sharathmk99 opened this issue Mar 2, 2024 · 1 comment
Closed

HTTP Transport commit is creating issue to init repo #3109

Sharathmk99 opened this issue Mar 2, 2024 · 1 comment
Assignees
Labels
area / SDK-storage Issue area: SDK and storage related issues help wanted Extra attention is needed phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release type / bug Issue type: something isn't working
Milestone

Comments

@Sharathmk99
Copy link
Contributor

🐛 Bug

To reproduce

HTTP transport for remote tracking is very cool, tried to init repo using master, but looks like we still have some code related to proto. Under aim/cli/upgrade/_legacy_repo we still have proto related code base so it's breaking to build,

Traceback (most recent call last):
  File "/usr/local/bin/aim", line 5, in <module>
    from aim.cli.cli import cli_entry_point
  File "/usr/local/lib/python3.9/site-packages/aim/cli/cli.py", line 12, in <module>
    from aim.cli.storage import commands as storage_commands
  File "/usr/local/lib/python3.9/site-packages/aim/cli/storage/commands.py", line 6, in <module>
    from aim.cli.upgrade.utils import convert_2to3
  File "/usr/local/lib/python3.9/site-packages/aim/cli/upgrade/utils.py", line 6, in <module>
    from aim.cli.upgrade._legacy_repo import (
  File "/usr/local/lib/python3.9/site-packages/aim/cli/upgrade/_legacy_repo/__init__.py", line 3, in <module>
    from aim.cli.upgrade._legacy_repo.metric_artifact import deserialize_pb
  File "/usr/local/lib/python3.9/site-packages/aim/cli/upgrade/_legacy_repo/metric_artifact.py", line 1, in <module>
    from aim.cli.upgrade._legacy_repo.proto.base_pb2 import BaseRecord
  File "/usr/local/lib/python3.9/site-packages/aim/cli/upgrade/_legacy_repo/proto/base_pb2.py", line 1, in <module>
    import google.protobuf
ModuleNotFoundError: No module named 'google.protobuf'

@mihran113 should we remove code related to legacy upgrade?
Thanks

Expected behavior

Environment

  • Aim Version (e.g., 3.0.1)
  • Python version
  • pip version
  • OS (e.g., Linux)
  • Any other relevant information

Additional context

@Sharathmk99 Sharathmk99 added help wanted Extra attention is needed type / bug Issue type: something isn't working labels Mar 2, 2024
@mihran113
Copy link
Contributor

Hey @Sharathmk99! Thanks a lot for reporting! I guess it's time to remove the 2to3 upgrade command, it's not worth keeping the protobuf as a dependency only for that.

@mihran113 mihran113 self-assigned this Mar 5, 2024
@mihran113 mihran113 added phase / in-progress Issue phase: issue is in the development phase area / SDK-storage Issue area: SDK and storage related issues labels Mar 5, 2024
@mihran113 mihran113 moved this to In-progress in Aim roadmap Mar 5, 2024
@mihran113 mihran113 added this to the v3.19.0 milestone Mar 5, 2024
@mihran113 mihran113 added phase / review-needed Issue phase: issues that are done and needs review phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release and removed phase / in-progress Issue phase: issue is in the development phase phase / review-needed Issue phase: issues that are done and needs review labels Mar 5, 2024
@alberttorosyan alberttorosyan moved this from In-progress to Done in Aim roadmap Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area / SDK-storage Issue area: SDK and storage related issues help wanted Extra attention is needed phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release type / bug Issue type: something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants